Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document or avoid breaking change in UserSessionModel #24096

Closed
2 tasks done
mhajas opened this issue Oct 18, 2023 · 0 comments · Fixed by #24134
Closed
2 tasks done

Document or avoid breaking change in UserSessionModel #24096

mhajas opened this issue Oct 18, 2023 · 0 comments · Fixed by #24134
Assignees
@mposolda
Labels
area/core kind/bug Categorizes a PR related to a bug
Milestone
23.0.0

Comments

@mhajas
Copy link
Contributor

mhajas commented Oct 18, 2023

Before reporting an issue

Area

core

Describe the bug

There was a breaking change introduced within: #22148

In UserSessionModel
https://github.com/keycloak/keycloak/pull/22148/files#diff-eb50821cebd4fd7d6f2b34d1f84412da5bffa4cccf7669e8ea9feea7f03a7039R138

There is a new method without default implementation which means all implementations need to be updated including community ones.

We should mention this in the release notes/migration guide or avoid this if possible (Maybe by a default implementation ).

Version

main

Expected behavior

Actual behavior

How to Reproduce?

Anything else?

No response
@mhajas mhajas added kind/bug Categorizes a PR related to a bug status/triage labels Oct 18, 2023
@ahus1 ahus1 added this to the 23.0.0 milestone Oct 18, 2023
@mposolda mposolda self-assigned this Oct 19, 2023
mposolda added a commit to mposolda/keycloak that referenced this issue Oct 19, 2023
@mposolda
Avoid breaking change in UserSessionModel
0619404 
closes keycloak#24096
@mposolda mposolda mentioned this issue Oct 19, 2023
Merged
mposolda added a commit that referenced this issue Oct 20, 2023
@mposolda @mhajas
Avoid breaking change in UserSessionModel (#24134)
829b709 
closes #24096


Co-authored-by: Michal Hajas <mhajas@redhat.com>
Yang-Xie-OSS pushed a commit to Hitachi/keycloak that referenced this issue Nov 21, 2023
@mposolda @mhajas @Yang-Xie-OSS
Avoid breaking change in UserSessionModel (keycloak#24134)
5e71853 
closes keycloak#24096


Co-authored-by: Michal Hajas <mhajas@redhat.com>
Yang-Xie-OSS pushed a commit to Hitachi/keycloak that referenced this issue Nov 22, 2023
@mposolda @mhajas @Yang-Xie-OSS
Avoid breaking change in UserSessionModel (keycloak#24134)
a680699 
closes keycloak#24096


Co-authored-by: Michal Hajas <mhajas@redhat.com>
srose pushed a commit to srose/keycloak that referenced this issue Dec 20, 2023
@mposolda @mhajas @srose
Avoid breaking change in UserSessionModel (keycloak#24134)
baffbc8 
closes keycloak#24096


Co-authored-by: Michal Hajas <mhajas@redhat.com>
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@mposolda @mhajas @kamontat
Avoid breaking change in UserSessionModel (keycloak#24134)
db390fc 
closes keycloak#24096

Co-authored-by: Michal Hajas <mhajas@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mposolda mposolda

Labels
area/core kind/bug Categorizes a PR related to a bug
Projects
None yet
Milestone
23.0.0
Development

Successfully merging a pull request may close this issue.

Avoid breaking change in UserSessionModel mposolda/keycloak
3 participants
@mposolda @ahus1 @mhajas