Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Store Removal: Delete container providers that were added to the base testsuite #24097

Closed
Tracked by #24111
sguilhen opened this issue Oct 18, 2023 · 2 comments · Fixed by #25168
Closed
Tracked by #24111

Map Store Removal: Delete container providers that were added to the base testsuite #24097

sguilhen opened this issue Oct 18, 2023 · 2 comments · Fixed by #25168
Assignees
@vramik
Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation) kind/enhancement Categorizes a PR related to an enhancement release/24.0.0

Comments

@sguilhen
Copy link
Contributor

Description

With the Map Store being removed, we have to delete the container providers that were introduced in the testsuite (PostgresContainerProvider, CockroachdbContainerProvider, HotRodContainerProvider)
@sguilhen sguilhen added area/storage Indicates an issue that touches storage (change in data layout or data manipulation) team/store kind/task labels Oct 18, 2023
@sguilhen sguilhen mentioned this issue Oct 18, 2023
Open
31 tasks
@vramik vramik self-assigned this Oct 31, 2023
@ahus1
Copy link
Contributor

ahus1 commented Nov 30, 2023

When doing this, please also remove the test case ZeroDowntimeTest which is currently ignored.

@vramik
Copy link
Contributor

vramik commented Nov 30, 2023

When doing this, please also remove the test case ZeroDowntimeTest which is currently ignored.

Thank you, I aim to do so: vramik@5115780#diff-1ad6d543fe20cf0b2b01cdab80d10e6743f423d18827522c1a177bdc46e43c46

vramik added a commit to vramik/keycloak that referenced this issue Nov 30, 2023
@vramik
Delete container providers from the base testsuite
1c19600 
Closes keycloak#24097

Signed-off-by: vramik <vramik@redhat.com>
@vramik vramik mentioned this issue Nov 30, 2023
Merged
vramik added a commit to vramik/keycloak that referenced this issue Dec 4, 2023
@vramik
Delete container providers from the base testsuite
cb7f151 
Closes keycloak#24097

Signed-off-by: vramik <vramik@redhat.com>
mhajas pushed a commit that referenced this issue Dec 4, 2023
@vramik
Delete container providers from the base testsuite (#25168)
6f37fef 
Closes #24097

Signed-off-by: vramik <vramik@redhat.com>
@mhajas mhajas added kind/enhancement Categorizes a PR related to an enhancement and removed kind/task labels Dec 5, 2023
srose pushed a commit to srose/keycloak that referenced this issue Dec 20, 2023
@vramik @srose
Delete container providers from the base testsuite (keycloak#25168)
4ee6b11 
Closes keycloak#24097

Signed-off-by: vramik <vramik@redhat.com>
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@vramik @kamontat
Delete container providers from the base testsuite (keycloak#25168)
75665f7 
Closes keycloak#24097

Signed-off-by: vramik <vramik@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@vramik @ShefeeqPM
Delete container providers from the base testsuite (keycloak#25168)
94688e2 
Closes keycloak#24097

Signed-off-by: vramik <vramik@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vramik vramik

Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation) kind/enhancement Categorizes a PR related to an enhancement release/24.0.0
Projects
Storage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete container providers from the base testsuite vramik/keycloak
4 participants
@sguilhen @vramik @ahus1 @mhajas