Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sign out action for offline sessions #24763

Closed
1 task done
ssilvert opened this issue Nov 14, 2023 · 1 comment · Fixed by #25577
Closed
1 task done

Remove sign out action for offline sessions #24763

ssilvert opened this issue Nov 14, 2023 · 1 comment · Fixed by #25577
Assignees
@hmlnarik
Labels
area/admin/ui impact/high kind/bug Categorizes a PR related to a bug release/23.0.4 team/ui

Comments

@ssilvert
Copy link
Contributor

ssilvert commented Nov 14, 2023 •
edited by hmlnarik

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

admin/ui

Describe the bug

[...] another issue related with same endpoints. When You signout a offline session the endpoint call for delete is /sessions instead /offline-sessions. These cause that the endpoint respond with a 404 and the offline session was not loged out.

Originally posted by @john2094 in #24523 (comment)

Version

nightly

Expected behavior

Offline session is logged out.

Actual behavior

404

How to Reproduce?

See description in this comment: #24523 (comment)

Anything else?

No response
@ssilvert ssilvert added kind/bug Categorizes a PR related to a bug status/triage labels Nov 14, 2023
@ssilvert ssilvert mentioned this issue Nov 14, 2023
Closed
1 task
@hmlnarik hmlnarik self-assigned this Nov 15, 2023
@hmlnarik
Copy link
Contributor

@john2094 The offline session cannot be logged out similarly to online sessions for historical reason, for further context check this thread: https://groups.google.com/g/keycloak-dev/c/3eWuGqEdABM/m/0AJiid61CwAJ.

Thus there should be no action for offline session logout, contrary to what is there now. The legacy admin console did not have the ability to destroy offline sessions (revoke offline tokens) either, only the ability to set not-before for a particular user or realm or log out corresponding online session if it existed. This is possible in the current admin console.

image

@hmlnarik hmlnarik changed the title 404 when signing out an offline session from admin console Remove _sign out_ action for offline sessions Nov 24, 2023
@hmlnarik hmlnarik changed the title Remove _sign out_ action for offline sessions Remove sign out action for offline sessions Nov 24, 2023
@jonkoops jonkoops modified the milestone: 23.0.1 Nov 24, 2023
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Dec 13, 2023
@hmlnarik
Do not show sign-out action for offline sessions
a680092 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Dec 14, 2023
@hmlnarik
Do not show sign-out action for offline sessions
9beee27 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
@hmlnarik hmlnarik mentioned this issue Dec 14, 2023
Merged
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Dec 14, 2023
@hmlnarik
Do not show sign-out action for offline sessions
74eb658 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Dec 14, 2023
@hmlnarik
Do not show sign-out action for offline sessions
1bf90b1 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
edewit pushed a commit that referenced this issue Dec 15, 2023
@hmlnarik
Do not show sign-out action for offline sessions (#25577)
c6ce859 
Closes: #24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
parnus01 pushed a commit to parnus01/keycloak that referenced this issue Dec 18, 2023
@hmlnarik
Do not show sign-out action for offline sessions (keycloak#25577)
c9987b1 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Signed-off-by: Danusorn Taboonyong <osacn_danusorn.taboonyong@krungthai.com>
srose pushed a commit to srose/keycloak that referenced this issue Dec 20, 2023
@hmlnarik @srose
Do not show sign-out action for offline sessions (keycloak#25577)
835273c 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Jan 2, 2024
@hmlnarik
Do not show sign-out action for offline sessions (keycloak#25577)
ec5b6f7 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
(cherry picked from commit c6ce859)
@hmlnarik hmlnarik mentioned this issue Jan 2, 2024
Merged
hmlnarik added a commit that referenced this issue Jan 2, 2024
@hmlnarik
Do not show sign-out action for offline sessions (#25577)
e3d2431 
Closes: #24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
(cherry picked from commit c6ce859)
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@hmlnarik @kamontat
Do not show sign-out action for offline sessions (keycloak#25577)
1edb778 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@hmlnarik @ShefeeqPM
Do not show sign-out action for offline sessions (keycloak#25577)
028bb1d 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
@hmlnarik @ahus1
Do not show sign-out action for offline sessions (keycloak#25577)
b1a6c72 
Closes: keycloak#24763

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmlnarik hmlnarik

Labels
area/admin/ui impact/high kind/bug Categorizes a PR related to a bug release/23.0.4 team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show sign-out action for offline sessions hmlnarik/keycloak
3 participants
@ssilvert @jonkoops @hmlnarik