New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LDAP Condition implementations #24767

Closed

1 task done

rmartinc opened this issue Nov 15, 2023 · 0 comments · Fixed by #24771

Closed

1 task done

Improve LDAP Condition implementations #24767

rmartinc opened this issue Nov 15, 2023 · 0 comments · Fixed by #24771

Assignees

Labels

area/ldap kind/bug

Milestone

Contributor

rmartinc commented Nov 15, 2023

Before reporting an issue

I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

ldap

Describe the bug

The idea behind this issue is improving LDAP Condition implementations to make the filter construction more secure. LDAP Conditions should be the only way to perform searches in an LDAP user provider and all filters should be constructed from Condition classes.

Version

nightly

Expected behavior

N/A

Actual behavior

N/A

How to Reproduce?

N/A

Anything else?

No response

The text was updated successfully, but these errors were encountered:

rmartinc added kind/bug status/triage labels

rmartinc self-assigned this

ghost added area/ldap team/store labels

rmartinc removed the status/triage label

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

52a102a

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc added this to the 24.0.0 milestone

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

5ee69cc

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

997b20b

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

b3f966b

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc mentioned this issue

Improve LDAP Condition implementations #24771

Merged

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

fd5fdee

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc added a commit to rmartinc/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

1cdc4bf

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

abstractj pushed a commit to rmartinc/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

2a189b4

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

abstractj pushed a commit to rmartinc/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

29171cf

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

abstractj closed this as completed in #24771

abstractj pushed a commit that referenced this issue


          Ensure that all LDAP conditions escape attribute values

c8009b4

Closes #24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

abstractj pushed a commit that referenced this issue


          Use conditions instead of String for filters and just use default esc…

4e7bd76

…ape strategy

Closes #24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

parnus01 pushed a commit to parnus01/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

940cd7a

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Danusorn Taboonyong <osacn_danusorn.taboonyong@krungthai.com>

parnus01 pushed a commit to parnus01/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

c4f2ae0

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Danusorn Taboonyong <osacn_danusorn.taboonyong@krungthai.com>

srose pushed a commit to srose/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

b7f2a3c

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

srose pushed a commit to srose/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

beb5fd7

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

rmartinc mentioned this issue

User Federation: Blind LDAP Injection in Users Search #26112

Closed

kamontat pushed a commit to kamontat/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

982ea6a

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>

kamontat pushed a commit to kamontat/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

d953dae

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>

ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

f634ede

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>

ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

118887a

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>

ahus1 pushed a commit to ahus1/keycloak that referenced this issue


          Ensure that all LDAP conditions escape attribute values

f3fe7e6

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

ahus1 pushed a commit to ahus1/keycloak that referenced this issue


          Use conditions instead of String for filters and just use default esc…

4c7edd8

…ape strategy

Closes keycloak#24767

Signed-off-by: rmartinc <rmartinc@redhat.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment