Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keycloak Admin UI - Help text not localized in Realm Events Setting UI #24783

Closed
1 task done
jsorah opened this issue Nov 15, 2023 · 0 comments · Fixed by #25599
Closed
1 task done

Keycloak Admin UI - Help text not localized in Realm Events Setting UI #24783

jsorah opened this issue Nov 15, 2023 · 0 comments · Fixed by #25599
Assignees
@jsorah
Labels
area/admin/ui impact/low kind/bug Categorizes a PR related to a bug release/24.0.0 team/ui

Comments

@jsorah
Copy link
Contributor

jsorah commented Nov 15, 2023

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

admin/ui

Describe the bug

Some of the hover help items do not have their localized text and appear to reference keys that do not exist.

image

User events settings

Save events -> save-user-eventsHelp
Clear user events -> user-clearEventsHelp

Admin events settings

Save events -> save-admin-eventsHelp
Clear admin events -> admin-clearEventsHelp

Version

nightly

Expected behavior

Helpful, localized help text.

Actual behavior

Not very helpful localization key name.

How to Reproduce?

Login to Admin Console of running Keycloak instance based off nightly

  • Nav to Realm settings
  • Click Events tab
  • Click "User Settings" - hover over ❔ icons on page
  • Click "Admin events settings" - hover over ❔ icons on page

Anything else?

likely related to #24316

I do see the text is present in the new message bundles, but I guess its generating the localization keys in a format that doesn't match what's defined in the bundle.
@jsorah jsorah added kind/bug Categorizes a PR related to a bug status/triage labels Nov 15, 2023
@jonkoops jonkoops modified the milestone: 23.0.0 Nov 15, 2023
jsorah added a commit to jsorah/keycloak that referenced this issue Dec 15, 2023
@jsorah
Update message keys for Realm Events Setting UI help text
5f9853a 
Closes keycloak#24783

Signed-off-by: Joshua Sorah <jsorah@gmail.com>
@jsorah jsorah mentioned this issue Dec 15, 2023
Merged
jonkoops pushed a commit that referenced this issue Jan 2, 2024
@jsorah
Update message keys for Realm Events Setting UI help text (#25599)
3042a89 
Closes #24783

Signed-off-by: Joshua Sorah <jsorah@gmail.com>
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@jsorah @kamontat
Update message keys for Realm Events Setting UI help text (keycloak#2…
121cd10 
…5599)

Closes keycloak#24783

Signed-off-by: Joshua Sorah <jsorah@gmail.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@jsorah @ShefeeqPM
Update message keys for Realm Events Setting UI help text (keycloak#2…
d404efe 
…5599)

Closes keycloak#24783

Signed-off-by: Joshua Sorah <jsorah@gmail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
@jsorah @ahus1
Update message keys for Realm Events Setting UI help text (keycloak#2…
b736135 
…5599)

Closes keycloak#24783

Signed-off-by: Joshua Sorah <jsorah@gmail.com>
@douglaspalmer douglaspalmer mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsorah jsorah

Labels
area/admin/ui impact/low kind/bug Categorizes a PR related to a bug release/24.0.0 team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update message keys for Realm Events Setting UI help text jsorah/keycloak
2 participants
@jonkoops @jsorah