Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make password visibility css classes configurable for themes #25016

Closed
dasniko opened this issue Nov 24, 2023 · 2 comments · Fixed by #25017
Closed

Make password visibility css classes configurable for themes #25016

dasniko opened this issue Nov 24, 2023 · 2 comments · Fixed by #25017
Labels
area/login/ui impact/low kind/bug Categorizes a PR related to a bug release/23.0.4 release/24.0.0 team/ui

Comments

@dasniko
Copy link
Contributor

dasniko commented Nov 24, 2023

Description

With #22067 a password visibility toggle was introduced.

The implemented code in the base them has some hardcoded css classes, although the base theme doesn't know about any css classes and only provides placeholders in class attributes, so that a theme concrete theme can configure its own class names through the themes.properties file.
With these hardcoded classnames and without placeholders, it's not possible in inherited themes to set custom css classnames.

That said, I suggest to change the relevant base templates to provide placesholders, which can be set by the theme.properties file and add the current hardcoded values to the keycloak theme. This way, there's no visible change for the default settings in Keycloak.

Discussion

No response

Motivation

No response

Details

I will also prepare a PR for the suggested changes.
@dasniko dasniko added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Nov 24, 2023
dasniko added a commit to dasniko/keycloak that referenced this issue Nov 24, 2023
@dasniko
make css classes for password visibility configurable through theme p…
8225e95 
…roperties

resolves keycloak#25016

Signed-off-by: Niko Köbler <niko@n-k.de>
@dasniko dasniko mentioned this issue Nov 24, 2023
Merged
@ghost ghost removed the status/triage label Nov 25, 2023
ahus1 pushed a commit that referenced this issue Nov 25, 2023
@dasniko
make css classes for password visibility configurable through theme p…
a5f276c 
…roperties

Closes #25016

Signed-off-by: Niko Köbler <niko@n-k.de>
@jonkoops jonkoops added kind/bug Categorizes a PR related to a bug impact/low team/ui area/login/ui backport/23.0 and removed kind/enhancement Categorizes a PR related to an enhancement labels Nov 26, 2023
@jonkoops
Copy link
Contributor

I think we can consider this a bug since all other functionalities in the login have similar ways of handling classes. I am marking this as a candidate to backport to v23.x.

@bnf
Copy link

bnf commented Dec 15, 2023

@jonkoops Is the backport to v23.x still planned/considered or has it been overseen as the issue is already closed?

srose pushed a commit to srose/keycloak that referenced this issue Dec 20, 2023
@dasniko @srose
make css classes for password visibility configurable through theme p…
ce06a66 
…roperties

Closes keycloak#25016

Signed-off-by: Niko Köbler <niko@n-k.de>
dasniko added a commit to dasniko/keycloak that referenced this issue Dec 21, 2023
@dasniko
make css classes for password visibility configurable through theme p…
ee7a96a 
…roperties

Closes keycloak#25016

Signed-off-by: Niko Köbler <niko@n-k.de>
(cherry picked from commit a5f276c)
@dasniko dasniko mentioned this issue Dec 21, 2023
Merged
ahus1 pushed a commit that referenced this issue Dec 22, 2023
@dasniko @ahus1
make css classes for password visibility configurable through theme p…
ca7b8d6 
…roperties

Closes #25016

Signed-off-by: Niko Köbler <niko@n-k.de>
(cherry picked from commit a5f276c)
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@dasniko @kamontat
make css classes for password visibility configurable through theme p…
51ec61e 
…roperties

Closes keycloak#25016

Signed-off-by: Niko Köbler <niko@n-k.de>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@dasniko @ShefeeqPM
make css classes for password visibility configurable through theme p…
d6677c6 
…roperties

Closes keycloak#25016

Signed-off-by: Niko Köbler <niko@n-k.de>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/login/ui impact/low kind/bug Categorizes a PR related to a bug release/23.0.4 release/24.0.0 team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make password visibility css classes configurable for themes dasniko/keycloak
4 participants
@bnf @jonkoops @dasniko @ahus1