Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in the balloon help of SAML Username Template Importer #25033

Closed
1 task done
hokuda opened this issue Nov 27, 2023 · 2 comments · Fixed by #25034
Closed
1 task done

Typo in the balloon help of SAML Username Template Importer #25033

hokuda opened this issue Nov 27, 2023 · 2 comments · Fixed by #25034
Assignees
@hokuda
Labels
area/core kind/bug Categorizes a PR related to a bug
Milestone
24.0.0

Comments

@hokuda
Copy link
Contributor

hokuda commented Nov 27, 2023

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

admin/ui

Describe the bug

The balloon help of "Template" in SAML Username Template Importer shows "${CLAIM.email | localpart}" as an example.
But actually CLAIM.email does not work. It should be replaced with "${ATTRIBUTE.email | localpart}".

Version

21.0.2/upstream

Expected behavior

It shows "${ATTRIBUTE.email | localpart}".

Actual behavior

It shows "${CLAIM.email | localpart}".

How to Reproduce?

Hover the cursor over the "?" of "Template" in SAML Username Template Importer of Identity Provider in the admin console.

Anything else?

No response
@hokuda hokuda added kind/bug Categorizes a PR related to a bug status/triage labels Nov 27, 2023
hokuda added a commit to hokuda/keycloak that referenced this issue Nov 27, 2023
@hokuda
Fix typo in the balloon help of SAML Username Template Importer
3523f11 
closes keycloak#25033
@hokuda hokuda mentioned this issue Nov 27, 2023
Merged
@ahus1
Copy link
Contributor

ahus1 commented Nov 27, 2023

Re-assigning this to the @keycloak/core-maintainers team as it is SAML related.

@rmartinc
Copy link
Contributor

Hi @hokuda! You are right, just a minor comment in the PR from my side. And thanks a lot!

@rmartinc rmartinc added this to the 24.0.0 milestone Nov 28, 2023
hokuda added a commit to hokuda/keycloak that referenced this issue Nov 28, 2023
@hokuda
Fix typo in the balloon help of SAML Username Template Importer
c4cc595 
closes keycloak#25033

Signed-off-by: hokuda <hisanobu.okuda@gmail.com>
pedroigor pushed a commit that referenced this issue Nov 29, 2023
@hokuda @pedroigor
Fix typo in the balloon help of SAML Username Template Importer
a83b9d1 
closes #25033

Signed-off-by: hokuda <hisanobu.okuda@gmail.com>
srose pushed a commit to srose/keycloak that referenced this issue Dec 20, 2023
@hokuda @srose
Fix typo in the balloon help of SAML Username Template Importer
b18d42b 
closes keycloak#25033

Signed-off-by: hokuda <hisanobu.okuda@gmail.com>
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@hokuda @kamontat
Fix typo in the balloon help of SAML Username Template Importer
8fcee60 
closes keycloak#25033

Signed-off-by: hokuda <hisanobu.okuda@gmail.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@hokuda @ShefeeqPM
Fix typo in the balloon help of SAML Username Template Importer
d937c40 
closes keycloak#25033

Signed-off-by: hokuda <hisanobu.okuda@gmail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hokuda hokuda

Labels
area/core kind/bug Categorizes a PR related to a bug
Projects
None yet
Milestone
24.0.0
Development

Successfully merging a pull request may close this issue.

Fix typo in the balloon help of SAML Username Template Importer hokuda/keycloak
3 participants
@hokuda @ahus1 @rmartinc