Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Store Removal: Remove protostream dependency #25288

Closed
Tracked by #24111
mhajas opened this issue Dec 5, 2023 · 2 comments · Fixed by #25869
Closed
Tracked by #24111

Map Store Removal: Remove protostream dependency #25288

mhajas opened this issue Dec 5, 2023 · 2 comments · Fixed by #25869
Assignees
@martin-kanis
Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation) kind/enhancement Categorizes a PR related to an enhancement release/24.0.0

Comments

@mhajas
Copy link
Contributor

mhajas commented Dec 5, 2023

This dependency was introduced for HotRod store and it is probably not necessary anymore.
@mhajas mhajas added area/storage Indicates an issue that touches storage (change in data layout or data manipulation) team/store kind/task labels Dec 5, 2023
@mhajas mhajas mentioned this issue Dec 5, 2023
Open
31 tasks
@mhajas mhajas added kind/enhancement Categorizes a PR related to an enhancement and removed kind/task labels Dec 5, 2023
@ahus1
Copy link
Contributor

ahus1 commented Dec 7, 2023

When resolving this, please make sure that remote store still works in Cross-DC. Thanks!

@mhajas
Copy link
Contributor Author

mhajas commented Dec 7, 2023

If I am not mistaken we are using this dependency only in the dependency management in the main pom so it should not cause any troubles but to be on the safe side we should check.

@martin-kanis martin-kanis self-assigned this Dec 11, 2023
martin-kanis added a commit to martin-kanis/keycloak that referenced this issue Jan 3, 2024
@martin-kanis
Map Store Removal: Remove protostream dependency
1e09289 
Closes keycloak#25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
@martin-kanis martin-kanis mentioned this issue Jan 3, 2024
Merged
martin-kanis added a commit to martin-kanis/keycloak that referenced this issue Jan 3, 2024
@martin-kanis
Map Store Removal: Remove protostream dependency
d4bccf8 
Closes keycloak#25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
ahus1 pushed a commit that referenced this issue Jan 3, 2024
@martin-kanis @ahus1
Map Store Removal: Remove protostream dependency
022e809 
Closes #25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
@ahus1 ahus1 mentioned this issue Jan 11, 2024
Closed
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@martin-kanis @kamontat
Map Store Removal: Remove protostream dependency
3f8bbff 
Closes keycloak#25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@martin-kanis @ShefeeqPM
Map Store Removal: Remove protostream dependency
ee99581 
Closes keycloak#25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
@martin-kanis @ahus1
Map Store Removal: Remove protostream dependency
8aa7439 
Closes keycloak#25288

Signed-off-by: Martin Kanis <mkanis@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-kanis martin-kanis

Labels
area/storage Indicates an issue that touches storage (change in data layout or data manipulation) kind/enhancement Categorizes a PR related to an enhancement release/24.0.0
Projects
Storage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map Store Removal: Remove protostream dependency martin-kanis/keycloak
3 participants
@martin-kanis @ahus1 @mhajas