Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X509 client certificate login label extends out of form #25770

Closed
magnhas opened this issue Dec 22, 2023 · 1 comment · Fixed by #25771
Closed

X509 client certificate login label extends out of form #25770

magnhas opened this issue Dec 22, 2023 · 1 comment · Fixed by #25771
Labels
area/login/ui kind/enhancement Categorizes a PR related to an enhancement release/24.0.0 team/ui

Comments

@magnhas
Copy link
Contributor

magnhas commented Dec 22, 2023

Description

X509 client certificate login label extends out of form.

Screenshot 2023-12-22 at 10 15 17

Discussion

No response

Motivation

Things should look nice.

Details

Add something like

label.pf-c-form__label.pf-c-form__label-text {
    overflow-wrap: break-word
}

to login.css.
@magnhas magnhas added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Dec 22, 2023
magnhas added a commit to magnhas/keycloak that referenced this issue Dec 22, 2023
@magnhas
Fix X509 client certificate login label
cdfa305 
Closes keycloak#25770
@magnhas magnhas mentioned this issue Dec 22, 2023
Merged
magnhas added a commit to magnhas/keycloak that referenced this issue Dec 22, 2023
@magnhas
Fix X509 client certificate login label
de6c6f2 
Closes keycloak#25770
magnhas added a commit to magnhas/keycloak that referenced this issue Dec 22, 2023
@magnhas
Fix X509 client certificate login label
fccff7b 
Closes keycloak#25770

Signed-off-by: Magnus Hård af Segerstad <magnus.hardafsegerstad@basalt.se>
@ahus1
Copy link
Contributor

ahus1 commented Dec 22, 2023

Once the PR is merged to main, your change will be included in the next major release of Keycloak which supposed to be Keycloak 24.

If you want it to be included in the next patch release of KC23, create a PR against the KC23 release branch which cherry-picks this change from the main branch (after the original PR is merged).

@ghost ghost removed the status/triage label Dec 22, 2023
ahus1 pushed a commit that referenced this issue Dec 22, 2023
@magnhas @ahus1
Fix X509 client certificate login label
78866df 
Closes #25770

Signed-off-by: Magnus Hård af Segerstad <magnus.hardafsegerstad@basalt.se>
kamontat pushed a commit to kamontat/keycloak that referenced this issue Jan 20, 2024
@magnhas @kamontat
Fix X509 client certificate login label
ad1c426 
Closes keycloak#25770

Signed-off-by: Magnus Hård af Segerstad <magnus.hardafsegerstad@basalt.se>
Signed-off-by: Kamontat Chantrachirathumrong <14089557+kamontat@users.noreply.github.com>
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this issue Jan 27, 2024
@magnhas @ShefeeqPM
Fix X509 client certificate login label
7f0ff52 
Closes keycloak#25770

Signed-off-by: Magnus Hård af Segerstad <magnus.hardafsegerstad@basalt.se>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
@magnhas @ahus1
Fix X509 client certificate login label
45a1987 
Closes keycloak#25770

Signed-off-by: Magnus Hård af Segerstad <magnus.hardafsegerstad@basalt.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/login/ui kind/enhancement Categorizes a PR related to an enhancement release/24.0.0 team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix X509 client certificate login label magnhas/keycloak
2 participants
@ahus1 @magnhas