New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin UI: Show realm display name on welcome page #25897
Comments
Yeah, this seems like a nice enhancement, I will add this to the backlog and mark it as 'help wanted' |
Hi @jonkoops , this looks like a good start to contribute to Keycloak. Can I work on this issue? |
Hii @jonkoops , I have been working on keycloak since 1 month. I think I'm able to solve this issue. If possible please assign this issue to me. |
I'll assign this to you @dipeshsingh253, thanks! @malavmevada if you are looking to pick up an issue there are others that can be picked up. |
Thanks @jonkoops for this opportunity !!! |
No problem, do let me know if you need any assistance 😄 |
Hi @jonkoops , I am following this guide to set development environment in my local, though it is taking a lot of time(I left it for somewhere around 2-3 hrs and when I came back it was still running) to execute |
It's likely that you need to pass To get started with development on the Administration Console you won't need to build Keycloak per-se, instead you can opt-to use a nightly build of Keycloak and develop against that. You can find information on how to to that in the README of the Administration Console. |
Hi @jonkoops , thanks for your assistance, now I can run keycloak-server and admin-ui locally. However, I would love to share a minor error I faced while setting up the local environment for Keycloak. First I tried to follow these instructions in Windows and I faced this error while executing the start script of keycloak-server.
But it worked smoothly when I followed the same steps on a Linux device. I will raise a PR by the end of this week for this as I currently don't have access to my Linux device. but I have already located the file where I need to make changes so it won't take much time. |
Hey @dipeshsingh253, good catch. Most of our developers are not on Windows machines, so it's likely that some of our scripts might not work on Windows. I have created a fix for this specific problem under #26025, could you review that PR and see if that resolves your issue? |
Hi @jonkoops , I have contributed to other projects as well, and there I had to fork it and work on it(it was mentioned in their contributor's guide), but here I can not see those same patterns in Keycloak's contributor guide, and instead of
Thanks !!! |
Hi @dipeshsingh253, we do assume that you fork our repository. I think the guide simply assumes that the user is familiar with the GitHub contribution guide. I agree that our documentation is lacking here, perhaps you could open a PR to add this link to the contribution guide?
If you feel like anything is missing from the contribution guide, feel free to open a PR to improve it, and I will make sure to get you a review. |
Hi @jonkoops , Sorry for the delay I just got my Linux device yesterday. I noticed that we are using the URL to get realmName to display on the welcome page, here this file, so I am not sure how can I get the displayName on welcome-page, we can see the displayName on login page for realm : I could check the file for the login page to get the display name, but I was not able to locate this file yet. If you have the idea can you help me where should I look for it? |
hi @dipeshsingh253 We have recently implemented this in the welcome tab. Please take a look at this code https://github.com/keycloak/keycloak/blob/main/js/apps/admin-ui/src/dashboard/Dashboard.tsx#L133 . I believe this is what you want to use as well. |
Hi @agagancarczyk , thanks I was exactly looking for this. But there is a bug and I am sure it should not be there somehow I am not able to display the realmName when the displayName for that realm is not available. I also verified the same scenario for the default dashboard of MasterRealm by removing the displayName for it. |
Try using |
Hi @jonkoops, I have created the PR. Please review it whenever you have time and let me know if there are any modifications needed. Thanks for the opportunity !!! |
Closes #25897 Signed-off-by: dipeshsingh253 <sinhdipesh@gmail.com>
Closes keycloak#25897 Signed-off-by: dipeshsingh253 <sinhdipesh@gmail.com>
The welcome page of the admin console uses the realm id, I think it should use the display name (if available) and fall back to the realm id.
In this example, the id is
cloudpak
and the display name is "Cloud Pak"The login page does this right and uses the display name where available.
The text was updated successfully, but these errors were encountered: