Empty error message when validation issue due the PersonNameProhibitedValidator validation

[mposolda]

Before reporting an issue

• I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

user-profile

Describe the bug

• Edit some attribute in admin console in user-profile and go to section Validations

• Try to add validator person-name-prohibited-characters

• There is configuration option Error message key, which has this tooltip Key of the error message in i18n bundle. Dafault message key is error-person-name-invalid-character . This implies to me that I can just leave this empty to have the default name.

• Issue 1: There is minor typo in the tooltip (Dafault)

• I save the validator. In the JSON, it is saved with empty error-message option.

    {
      "name": "my-attribute",
      "displayName": "",
      "validations": {
        "person-name-prohibited-characters": {
          "error-message": ""
        }
      },

• Issue 2: Now I try to edit some user and I fill my-attribute with incorrect value like Jo&hn . There is only error message my-attribute without any further explanation of what was wrong. Reason is, that default error message was not applied, but instead, it used empty error message. See screenshot

NOTE: Same issue happens also for some other validators (like PatternValidator or UsernameProhibitedCharactersValidator)

Version

nightly

Expected behavior

Some more appropriate error message like my attribute has invalid characters instead of just my attribute without any explanation. Basically when "error message" parameter is not null, but blank, it can be still good to fallback to default error message.

Actual behavior

Error message my-attribute without any explanation (See screenshot)

How to Reproduce?

See above

Anything else?

Not sure if this can be improved also in the UI layer and when attempting to save validator with some empty configuration parameter, it is considered that this configuration parameter was not used at all (rather than adding this parameter with empty value). So in my case, it can just save validator without error-message parameter like:

      "validations": {
        "person-name-prohibited-characters": {}
      },

instead of:

      "validations": {
        "person-name-prohibited-characters": {
          "error-message": ""
        }
      },

This would need to be fixed in UI layer though...