Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account console confusing with WebAuthn #27820

Closed
1 of 2 tasks
hmlnarik opened this issue Mar 12, 2024 · 1 comment · Fixed by #27935 or #28076
Closed
1 of 2 tasks

Account console confusing with WebAuthn #27820

hmlnarik opened this issue Mar 12, 2024 · 1 comment · Fixed by #27935 or #28076
Assignees
Labels
area/account/ui kind/bug Categorizes a PR related to a bug kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks release/24.0.2 release/25.0.0 team/ui
Milestone

Comments

@hmlnarik
Copy link
Contributor

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

account/ui

Describe the bug

Account console v3 is confusing at least when WebAuthn is enabled. See the picture below:

This was rendered using the following JSON:

[
    {
        "type": "password",
        "category": "basic-authentication",
        "displayName": "password-display-name",
        "helptext": "password-help-text",
        "iconCssClass": "kcAuthenticatorPasswordClass",
        "updateAction": "UPDATE_PASSWORD",
        "removeable": false,
        "userCredentialMetadatas": [
            {
                "credential": {
                    "id": "d86e83d4-9893-4fcf-8c97-bc01aa67d228",
                    "type": "password",
                    "createdDate": 1710251125241,
                    "credentialData": "{\"hashIterations\":210000,\"algorithm\":\"pbkdf2-sha512\",\"additionalParameters\":{}}"
                }
            }
        ]
    },
    {
        "type": "otp",
        "category": "two-factor",
        "displayName": "otp-display-name",
        "helptext": "otp-help-text",
        "iconCssClass": "kcAuthenticatorOTPClass",
        "createAction": "CONFIGURE_TOTP",
        "removeable": true,
        "userCredentialMetadatas": []
    },
    {
        "type": "webauthn",
        "category": "two-factor",
        "displayName": "webauthn-display-name",
        "helptext": "webauthn-help-text",
        "iconCssClass": "kcAuthenticatorWebAuthnClass",
        "createAction": "webauthn-register",
        "removeable": true,
        "userCredentialMetadatas": [
            {
                "credential": {
                    "id": "df335ecd-996f-4f77-8b54-465d19db110f",
                    "type": "webauthn",
                    "userLabel": "WebAuthn Authenticator (Default Label)",
                    "createdDate": 1710251197722,
                    "credentialData": "{\"aaguid\":\"00000000-0000-0000-0000-000000000000\",\"credentialId\":\"n9zgOzGPbL3b2Ki8GuJ8nr87hOT+2se+56Vg/lhyPU0=\",\"counter\":1,\"credentialPublicKey\":\"pQECAyYgASFYILmgt9ZBModiJ-yQxp7GsyjiYRUVRcmElkaoV7x2ySeKIlggJAox0K3-poP8nEcQKKCzs199uFcJTWzX9rEUihVjrwk\",\"attestationStatementFormat\":\"none\",\"transports\":[\"usb\"]}"
                }
            }
        ]
    },
    {
        "type": "webauthn-passwordless",
        "category": "passwordless",
        "displayName": "webauthn-passwordless-display-name",
        "helptext": "webauthn-passwordless-help-text",
        "iconCssClass": "kcAuthenticatorWebAuthnPasswordlessClass",
        "createAction": "webauthn-register-passwordless",
        "removeable": true,
        "userCredentialMetadatas": []
    }
]

Version

main

Regression

  • The issue is a regression

Expected behavior

It is clear which section is Password, OTP, WebAuthn Passwordless, and WebAuthn

Actual behavior

It is unclear which section is OTP, which WebAuthn.

How to Reproduce?

Enable passwordless and go to account console.

Anything else?

No response

@hmlnarik hmlnarik added kind/bug Categorizes a PR related to a bug action/priority-important labels Mar 12, 2024
@hmlnarik hmlnarik self-assigned this Mar 12, 2024
@keycloak-github-bot keycloak-github-bot bot added kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks and removed priority/important Must be worked on very soon action/priority-regression labels Mar 12, 2024
@keycloak-github-bot keycloak-github-bot bot added this to the 25.0.0 milestone Mar 12, 2024
@hmlnarik
Copy link
Contributor Author

This is actually a regression from v2 console, updating since v3 is now the default

hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 13, 2024
Fixes: keycloak#27820
Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 15, 2024
Fixes: keycloak#27820
Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 15, 2024
Fixes: keycloak#27820
Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 15, 2024
Fixes: keycloak#27820
Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 18, 2024
Fixes: keycloak#27820
Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
ssilvert pushed a commit that referenced this issue Mar 18, 2024
Fixes: #27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 19, 2024
Fixes: keycloak#27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
(cherry picked from commit 19061fb)
hmlnarik added a commit to hmlnarik/keycloak that referenced this issue Mar 20, 2024
Fixes: keycloak#27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
(cherry picked from commit 19061fb)
hmlnarik added a commit that referenced this issue Mar 20, 2024
Fixes: #27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
(cherry picked from commit 19061fb)
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
Fixes: keycloak#27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
@hmlnarik hmlnarik linked a pull request Mar 25, 2024 that will close this issue
tondrusk pushed a commit to tondrusk/keycloak that referenced this issue Mar 25, 2024
Fixes: keycloak#27820

Signed-off-by: Hynek Mlnarik <hmlnarik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/account/ui kind/bug Categorizes a PR related to a bug kind/regression priority/blocker Highest Priority. Has a deadline and it blocks other tasks release/24.0.2 release/25.0.0 team/ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants