Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truststore handling for the Operator is not documented #27892

Closed
1 of 2 tasks
ahus1 opened this issue Mar 14, 2024 · 1 comment · Fixed by #28015
Closed
1 of 2 tasks

Truststore handling for the Operator is not documented #27892

ahus1 opened this issue Mar 14, 2024 · 1 comment · Fixed by #28015
Assignees
Labels
area/operator Keycloak.X Operator kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon release/24.0.2 release/25.0.0 team/cloud-native

Comments

@ahus1
Copy link
Contributor

ahus1 commented Mar 14, 2024

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

operator

Describe the bug

KC24 introduced adding truststores via the CR, and this is documented in the release notes.

It seems that this is missing in the regular Keycloak docs, so people won't be able to find it.

Also the documentation of the CR as shown in OpenShift is very minimal, and doesn't show what to put into that "object" ("Details" is missing).

image

Version

main

Regression

  • The issue is a regression

Expected behavior

Documentation on https://www.keycloak.org/operator/advanced-configuration on how to use truststores.

Actual behavior

Documentation exists only in the release notes.

How to Reproduce?

Search for "truststores:" in all *.adoc files in the project

Anything else?

This would be a candidate for a KC24 backport.

cc: @vmuzikar, @shawkins

@ahus1 ahus1 added kind/bug Categorizes a PR related to a bug status/triage labels Mar 14, 2024
@vmuzikar
Copy link
Contributor

@ahus1 Thank you for creating the issue. It is a valid concern that some documentation around Truststore in Operator deployments would be good. The rationale behind why most options are not explicitly documented in the Operator context is that the options are either self-describing and it is clear from the CRD, or that it's a server option that is already documented in server guides.

However, for the truststore I agree it's not quite clear and we can do better. The config option has a different name in CRD than in server, and on top of that has a specific format as it requires referring to a Secret. Worth mentioning might be also that we configure Keycloak to trust the K8s CA by default.

@shawkins Could you please look into it when you get a chance?

shawkins added a commit to shawkins/keycloak that referenced this issue Mar 18, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/keycloak that referenced this issue Mar 20, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/keycloak that referenced this issue Mar 21, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar pushed a commit that referenced this issue Mar 22, 2024
closes: #27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
edewit pushed a commit to edewit/keycloak that referenced this issue Mar 22, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit pushed a commit to edewit/keycloak that referenced this issue Mar 22, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit added a commit that referenced this issue Mar 22, 2024
* changed to use ui-shared

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* doc: add keycloak cr truststores (#28015)

closes: #27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Steven Hawkins <shawkins@redhat.com>
shawkins added a commit to shawkins/keycloak that referenced this issue Mar 22, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 6cc6610)
vmuzikar pushed a commit that referenced this issue Mar 22, 2024
closes: #27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 6cc6610)
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
* changed to use ui-shared

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* doc: add keycloak cr truststores (keycloak#28015)

closes: keycloak#27892

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Co-authored-by: Steven Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator Keycloak.X Operator kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon release/24.0.2 release/25.0.0 team/cloud-native
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants