Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect clients which refresh their access tokens too early #28311

Open
ahus1 opened this issue Mar 30, 2024 · 2 comments · May be fixed by #28312
Open

Detect clients which refresh their access tokens too early #28311

ahus1 opened this issue Mar 30, 2024 · 2 comments · May be fixed by #28312
Assignees
Labels
kind/enhancement Categorizes a PR related to an enhancement status/triage

Comments

@ahus1
Copy link
Contributor

ahus1 commented Mar 30, 2024

Description

Sometimes clients don't follow best practices to fresh their access token only when they are about to expire.
This creates a higher load on Keycloak than necessary.

Discussion

#14040 (comment)

Motivation

Administrators should have a simple way to detect this to investigate their clients.

Details

This can be done by storing additional information in events and providing an event listener which logs warnings if such a situation arises.

@ahus1 ahus1 added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Mar 30, 2024
@ahus1 ahus1 self-assigned this Mar 30, 2024
ahus1 added a commit to ahus1/keycloak that referenced this issue Mar 30, 2024
Closes keycloak#28311

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@daviddelannoy
Copy link
Contributor

Hi @ahus1

Thanks a lot for this improvement. It will be very useful to detect and fix bad implementations like the ones that are guessed in issue #14040

@ahus1
Copy link
Contributor Author

ahus1 commented Apr 2, 2024

@daviddelannoy - thank you for your feedback. There is already a draft PR #28312, and I'd be happy to receive your feedback on the outlined behavior and design there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes a PR related to an enhancement status/triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants