Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details to error messages, especially around refresh tokens #28429

Closed
ahus1 opened this issue Apr 4, 2024 · 2 comments · Fixed by #28430
Closed

Add details to error messages, especially around refresh tokens #28429

ahus1 opened this issue Apr 4, 2024 · 2 comments · Fixed by #28430
Assignees
@ahus1
Labels
kind/enhancement Categorizes a PR related to an enhancement release/24.0.4 release/25.0.0 team/core-iam

Comments

@ahus1
Copy link
Contributor

ahus1 commented Apr 4, 2024

Description

When Keycloak logs errors about refreshing tokens, the logged information misses some details:

  • The error code is set, but the details (as submitted to the client) are missing, which could provide details on what is actually happening. So the caller has more information at hand than the admin looking at the logs.
  • The logs miss the session ID. We have it in multiple other places (actually in every token that we hand out), but not in the logs. This would allow tracking all events that happen for this session.

Discussion

#14040 (comment)

Motivation

Provide means to analyze REFRESH_TOKEN_ERROR causes by looking at the logs.

Details

I'll provide a PR
@ahus1 ahus1 added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Apr 4, 2024
@ahus1 ahus1 self-assigned this Apr 4, 2024
ahus1 added a commit to ahus1/keycloak that referenced this issue Apr 4, 2024
@ahus1
Add error details to events to be able to track down root causes
e0658c3 
Closes keycloak#28429

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
This was referenced Apr 4, 2024
Merged
Closed
ahus1 added a commit to ahus1/keycloak that referenced this issue Apr 4, 2024
@ahus1
Add error details to events to be able to track down root causes
50f4f18 
Closes keycloak#28429

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
mposolda pushed a commit that referenced this issue Apr 4, 2024
@ahus1 @mposolda
Add error details to events to be able to track down root causes
647bce4 
Closes #28429

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
ahus1 added a commit to ahus1/keycloak that referenced this issue Apr 4, 2024
@ahus1
Add error details to events to be able to track down root causes
f0a6127 
Closes keycloak#28429

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 mentioned this issue Apr 4, 2024
Merged
@ahus1
Copy link
Contributor Author

ahus1 commented Apr 5, 2024

For now decided to not backport it to 22 as the longer event descriptions might not fit the database column for the details json, which has been extended yet in that version.

@daviddelannoy
Copy link
Contributor

thanks for that @ahus1 it will be useful

No worries about backport, upgrades are required anyway ;-)

ahus1 added a commit that referenced this issue Apr 16, 2024
@ahus1
Add error details to events to be able to track down root causes
261b689 
Closes #28429

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 mentioned this issue Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahus1 ahus1

Labels
kind/enhancement Categorizes a PR related to an enhancement release/24.0.4 release/25.0.0 team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error details to events to be able to track down root causes ahus1/keycloak
2 participants
@ahus1 @daviddelannoy