Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use PersisterLastSessionRefreshStore when persistent sessions are enabled #29144

Closed
Tracked by #28265
mhajas opened this issue Apr 29, 2024 · 0 comments · Fixed by #29210
Closed
Tracked by #28265

Do not use PersisterLastSessionRefreshStore when persistent sessions are enabled #29144

mhajas opened this issue Apr 29, 2024 · 0 comments · Fixed by #29210
Assignees
@mhajas
Labels
release/25.0.0

Comments

@mhajas
Copy link
Contributor

mhajas commented Apr 29, 2024 •
edited

This:

keycloak/model/infinispan/src/main/java/org/keycloak/models/sessions/infinispan/UserSessionAdapter.java

Lines 228 to 235 in d55a8b0

if (offline) {
// Received the message from the other DC that we should update the lastSessionRefresh in local cluster. Don't update DB in that case.
// The other DC already did.
Boolean ignoreRemoteCacheUpdate = (Boolean) session.getAttribute(CrossDCLastSessionRefreshListener.IGNORE_REMOTE_CACHE_UPDATE);
if (ignoreRemoteCacheUpdate == null || !ignoreRemoteCacheUpdate) {
provider.getPersisterLastSessionRefreshStore().putLastSessionRefresh(session, entity.getId(), realm.getId(), lastSessionRefresh);
}
}

should not be executed
@mhajas mhajas mentioned this issue Apr 29, 2024
Open
@mhajas mhajas changed the title Use PersisterLastSessionRefreshStore also for online sessions Do not use PersisterLastSessionRefreshStore when persistent sessions are enabled Apr 29, 2024
@mhajas mhajas self-assigned this May 2, 2024
mhajas added a commit to mhajas/keycloak that referenced this issue May 2, 2024
@mhajas
Do not use LastSessionRefreshPersister with persistent user sessions …
952b669 
…enabled

Closes keycloak#29144

Signed-off-by: Michal Hajas <mhajas@redhat.com>
@mhajas mhajas mentioned this issue May 2, 2024
Merged
mhajas added a commit to mhajas/keycloak that referenced this issue May 2, 2024
@mhajas
Do not use LastSessionRefreshPersister with persistent user sessions …
7da53d4 
…enabled

Closes keycloak#29144

Signed-off-by: Michal Hajas <mhajas@redhat.com>
mhajas added a commit to mhajas/keycloak that referenced this issue May 3, 2024
@mhajas
Do not use LastSessionRefreshPersister with persistent user sessions …
d2d26cf 
…enabled

Closes keycloak#29144

Signed-off-by: Michal Hajas <mhajas@redhat.com>
mhajas added a commit to mhajas/keycloak that referenced this issue May 3, 2024
@mhajas
Do not use LastSessionRefreshPersister with persistent user sessions …
7fe4563 
…enabled

Closes keycloak#29144

Signed-off-by: Michal Hajas <mhajas@redhat.com>
ahus1 pushed a commit that referenced this issue May 6, 2024
@mhajas @ahus1
Do not use LastSessionRefreshPersister with persistent user sessions …
8b715d3 
…enabled

Closes #29144

Signed-off-by: Michal Hajas <mhajas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhajas mhajas

Labels
release/25.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not use LastSessionRefreshPersister with persistent user sessions … mhajas/keycloak
1 participant
@mhajas