Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-server-feature does not work for auth-server-quarkus-embedded #29259

Closed
1 of 2 tasks
mhajas opened this issue May 3, 2024 · 0 comments · Fixed by #30045
Closed
1 of 2 tasks

auth-server-feature does not work for auth-server-quarkus-embedded #29259

mhajas opened this issue May 3, 2024 · 0 comments · Fixed by #30045
Assignees
Labels
area/testsuite Indicates an issue on the Testsuite area kind/bug Categorizes a PR related to a bug release/25.0.0 team/continuous-testing

Comments

@mhajas
Copy link
Contributor

mhajas commented May 3, 2024

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

testsuite

Describe the bug

It seems this:

is not applied for

https://github.com/keycloak/keycloak/blob/8c3f7cc6e92ca8327cc6ab722b4e8565ca727dbd/testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/arquillian/containers/KeycloakQuarkusEmbeddedDeployableContainer.java

A possible fix could be to move a call to the method addFeaturesOption:

but we need to make sure it is added only for the build command in the case of auth-server-quarkus.

Version

main

Regression

  • The issue is a regression

Expected behavior

The option works for both auth-server-quarkus and embedded

Actual behavior

It works only for auth-server-quarkus

How to Reproduce?

Run some test with -Dauth.server.feature=persistent-user-sessions with both -Pauth-server-quarkus and -Pauth-server-quarkus-embedded and check the Keycloak startup log contains:

Experimental features enabled: persistent-user-sessions:v1

only with auth-server-quarkus

Note: make sure

PERSISTENT_USER_SESSIONS("Persistent online user sessions across restarts and upgrades", Type.EXPERIMENTAL),

is still experimental, otherwise test with other experimental feature. You can see features here:
https://github.com/keycloak/keycloak/blob/main/common/src/main/java/org/keycloak/common/Profile.java#L109

Anything else?

No response

@mhajas mhajas added kind/bug Categorizes a PR related to a bug status/triage labels May 3, 2024
@keycloak-github-bot keycloak-github-bot bot added area/testsuite Indicates an issue on the Testsuite area team/continuous-testing labels May 3, 2024
pruivo added a commit to pruivo/keycloak that referenced this issue May 31, 2024
pruivo added a commit to pruivo/keycloak that referenced this issue May 31, 2024
Fixes keycloak#29259

Signed-off-by: Pedro Ruivo <pruivo@redhat.com>
@pruivo pruivo self-assigned this May 31, 2024
mhajas pushed a commit that referenced this issue Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testsuite Indicates an issue on the Testsuite area kind/bug Categorizes a PR related to a bug release/25.0.0 team/continuous-testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants