Initial bootstrap admin #10661
Merged
Initial bootstrap admin #10661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
force-pushed
the
issue-9843-initial-admin
branch
from
3a49a20
to
fb81957
Compare
vmuzikar
requested changes
Mar 10, 2022
operator/src/main/java/org/keycloak/operator/v2alpha1/KeycloakAdminSecret.java
Outdated
Show resolved
Hide resolved
operator/src/main/java/org/keycloak/operator/v2alpha1/KeycloakAdminSecret.java
Outdated
Show resolved
Hide resolved
operator/src/main/java/org/keycloak/operator/v2alpha1/KeycloakAdminSecret.java
Outdated
Show resolved
Hide resolved
operator/src/test/java/org/keycloak/operator/KeycloakDeploymentE2EIT.java
Show resolved
Hide resolved
operator/src/test/java/org/keycloak/operator/KeycloakDeploymentE2EIT.java
Outdated
Show resolved
Hide resolved
vmuzikar
added
area/operator
andreaTP
force-pushed
the
issue-9843-initial-admin
branch
3 times, most recently
from
786d67b
to
05c7880
Compare
|
@vmuzikar ready for next round! 🎉 |
andreaTP
force-pushed
the
issue-9843-initial-admin
branch
from
05c7880
to
29c31fe
Compare
vmuzikar
requested changes
Mar 11, 2022
Comment on lines
+269
to
+270
| AtomicReference<String> adminUsername = new AtomicReference<>(); | ||
| AtomicReference<String> adminPassword = new AtomicReference<>(); |
There was a problem hiding this comment.
Is the AtomicReference really necessary? Awaitility doesn't use threads AFAIK.
There was a problem hiding this comment.
We are using those values in lambdas and the IDE screams if they are not final or AtomicRefs
There was a problem hiding this comment.
Ah, right. The "effectively final" rule...
operator/src/test/java/org/keycloak/operator/KeycloakDeploymentE2EIT.java
Show resolved
Hide resolved
operator/src/test/java/org/keycloak/operator/KeycloakDeploymentE2EIT.java
Show resolved
Hide resolved
vmuzikar
approved these changes
Mar 14, 2022
abstractj
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9843
NDR: This is a stop gap solution.