[#10616] Incorrect username logged for federated accounts #10662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mposolda
approved these changes
Mar 10, 2022
tyandor
pushed a commit
to tyandor/keycloak
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10616
Just adding two lines to set the ATTEMPTED_USERNAME when doing a brokered login. It's added when a federated user is found or when the first login flow is needed. The latter is just in case of an error or similar.
Also added a new test class because I didn't find a good place to add the tests. So I created a new OIDC broker test that extends
AbstractBrokerTestand checks the events, normal login (first login flow and existing) and doing a form wrong login before (same two cases).