Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot execute Old Admin Console tests #13887

Merged
merged 1 commit into from Aug 29, 2022
Merged

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Aug 19, 2022

Fixes #14005

Pipeline MR: https://keycloak-gitlab.com/keycloak/keycloak-pipeline/-/merge_requests/172

@miquelsi @nchopra27 Could you please take a look at it? Thanks

@mabartos mabartos changed the title Admin Console tests failing Old Admin Console tests failing Aug 19, 2022
nehachopra27
nehachopra27 previously approved these changes Aug 23, 2022
Copy link
Contributor

@nehachopra27 nehachopra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin, LGTM!

@mabartos
Copy link
Contributor Author

I need to check the pipeline run with the Old Account tests execution.

@mabartos mabartos changed the title Old Admin Console tests failing Cannot execute Old Admin Console tests Aug 25, 2022
@mabartos
Copy link
Contributor Author

@nehachopra27 Thanks for the review! It's possible to properly execute tests with the Old Admin console.

https://keycloak-jenkins.com/job/universal-test-pipeline-server/2082/

The attached failures are directly related to the #10997 issue. Everything works as expected.

@mabartos
Copy link
Contributor Author

Changed only the commit message.

@mabartos
Copy link
Contributor Author

The QS test failures are not related to this PR. @nehachopra27 Could you please approve it again? Thanks :)

@nehachopra27
Copy link
Contributor

Changes look good to me, Thanks!

@mabartos
Copy link
Contributor Author

/rerun

@pdrozd pdrozd merged commit 090f7f8 into keycloak:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot execute Old Admin Console tests
3 participants