Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper variable declaration for AuthZ JS #14561

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Sep 23, 2022

Adds a missing variable deceleration for the AuthZ JS adapter. This worked before, but since Strict Mode was enabled due to addition of a build step this now throws at runtime.

Closes #14445.

@jonkoops jonkoops self-assigned this Sep 23, 2022
@jonkoops jonkoops added kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon impact/high area/adapter/javascript labels Sep 23, 2022
@pedroigor
Copy link
Contributor

@jonkoops Thanks

@ssilvert ssilvert merged commit c56b69b into keycloak:main Sep 23, 2022
@jonkoops jonkoops deleted the declare-var branch September 23, 2022 15:46
@jonkoops jonkoops added this to the 19.0.3 milestone Sep 23, 2022
@stianst stianst removed this from the 19.0.3 milestone Sep 26, 2022
stianst pushed a commit to stianst/keycloak that referenced this pull request Oct 6, 2022
stianst added a commit that referenced this pull request Oct 6, 2022
Co-authored-by: Jon Koops <jonkoops@gmail.com>
@mabartos mabartos mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/adapter/javascript impact/high kind/bug Categorizes a PR related to a bug priority/important Must be worked on very soon team/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing variable declaration in AuthZ JS
5 participants