Fix attribute deleted from LDAP is not immediately reflected even if it is "Always Read Value From LDAP" #15929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhajas
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Thank you for the PR @wadahiro! The fix looks correct to me.
However, testing can be improved a little bit in our new model tests. I created an enhanced version of your test here:mhajas@0d4bac2
Could you please remove your test and add the one from the commit above to this PR?
wadahiro
force-pushed
the
issue-15927
branch
from
13f1d34
to
591595b
Compare
wadahiro
force-pushed
the
issue-15927
branch
from
591595b
to
5852109
Compare
@mhajas Thank you for your review. I fixed my commit and rebased on the latest main branch. Could you check it again? |
mhajas
previously approved these changes
Mar 14, 2023
|
@wadahiro The PR now has some conflict, could you please rebase? |
ghost
added
the
…it is "Always Read Value From LDAP"
|
@mhajas I rebased it again. |
mhajas
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15927