Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading TLS keys from a PKCS11 keystore #17099

Closed
wants to merge 2 commits into from

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented Feb 14, 2023

Closes #17098

  • Allow using PKCS#11 to load key material from a PKCs#11 compliant cryptographic device
  • Added a pkcs11-config-file build option to make it easier to configure the SunPKCS11 security provider and avoid users statically/manually setting the provider configuration in the Java security properties.
  • Customize Quarkus HttpServerOptions to enable HTTPS even though no key store file is provided.
  • For now, we assume the PIN provided via https-key-store-password is the same for any key alias in the keystore.

I'm not sure yet how to test this because we are going to need something SoftHSM installed in the CI/CD env.

We can also use a custom docker file in our test suite to run tests using a container where SoftHSM is pre-installed. I did not manage to achieve that because I'm not able to install SoftHSM using our container image as a base image (even after executing microdnf as root). Any help is appreciated.

Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if to announce this in the official documentation if we don't test this.

Is it possible to at least add some warning at the beginning of this docs section like This is not officially supported and is only experimental ... or something like that? We can consider removing if we have automated tests for this.

Also the option pkcs11-config-file should be likely hidden from the kc.sh --help until we figure this (but looks like it is already).

For the context of testing with FIPS, we can/should likely test with NSS. That's for example what EAP also supports in their docs as NSS is fips-approved stuff. But I don't consider this as a big priority TBH.

Overally, I don't see PKCS11 as a "must have" for RHBK 22.

@pedroigor
Copy link
Contributor Author

Hold

@pedroigor pedroigor closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support loading TLS keys from a PKCS11 keystore
3 participants