Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs changes for running the adapters with EAP7 and jdk-17 #19295

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

rmartinc
Copy link
Contributor

Closes: #19273

Missing documentation changes for #19273. The changes are for the EAP product but this way they are also added for upstream.

@rmartinc rmartinc requested a review from a team as a code owner March 24, 2023 08:57
mposolda
mposolda previously approved these changes Mar 24, 2023
@mposolda mposolda requested a review from andymunro March 24, 2023 09:30
@mposolda mposolda self-assigned this Mar 24, 2023
@@ -113,6 +113,8 @@ $ ./bin/jboss-cli.sh -c --file=bin/adapter-elytron-install.cli
----
+
NOTE: It is possible to use the legacy non-Elytron adapter on JBoss EAP 7.1 or newer as well, meaning you can use `adapter-install-offline.cli`
+
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. But note that the new java version makes the elytron variant compulsory (do not use the legacy adapter with JDK 17) and, after running the adapter CLI file, the EAP provided `enable-elytron-se17.cli` script should be executed. Both scripts are necessary, in that order, to configure the elytron adapter and then remove the incompatible EAP subsystems. Check https://access.redhat.com/articles/6956863[the following EAP article] for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. But note that the new java version makes the elytron variant compulsory (do not use the legacy adapter with JDK 17) and, after running the adapter CLI file, the EAP provided `enable-elytron-se17.cli` script should be executed. Both scripts are necessary, in that order, to configure the elytron adapter and then remove the incompatible EAP subsystems. Check https://access.redhat.com/articles/6956863[the following EAP article] for more information.
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. Note that the new java version makes the elytron variant compulsory, so do not use the legacy adapter with JDK 17. Also, after running the adapter CLI file, execute the `enable-elytron-se17.cli` script provided by EAP. Both scripts are necessary to configure the elytron adapter and remove the incompatible EAP subsystems. For more details, see this https://access.redhat.com/articles/6956863[Security Configuration Changes] article.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -70,6 +70,8 @@ ifeval::[{project_product}==true]
$ cd $JBOSS_HOME
$ ./bin/jboss-cli.sh -c --file=bin/adapter-elytron-install-saml.cli
----
+
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. But note that the new java version makes the elytron variant compulsory (do not use the legacy adapter with JDK 17) and, after running the adapter CLI file, the EAP provided `enable-elytron-se17.cli` script should be executed. Both scripts are necessary, in that order, to configure the elytron adapter and then remove the incompatible EAP subsystems. Check https://access.redhat.com/articles/6956863[the following EAP article] for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. But note that the new java version makes the elytron variant compulsory (do not use the legacy adapter with JDK 17) and, after running the adapter CLI file, the EAP provided `enable-elytron-se17.cli` script should be executed. Both scripts are necessary, in that order, to configure the elytron adapter and then remove the incompatible EAP subsystems. Check https://access.redhat.com/articles/6956863[the following EAP article] for more information.
NOTE: https://access.redhat.com/articles/2026253#EAP_74[EAP supports OpenJDK 17 and Oracle JDK 17] since 7.4.CP7 and 7.4.CP8 respectively. Note that the new java version makes the elytron variant compulsory, so do not use the legacy adapter with JDK 17. Also, after running the adapter CLI file, execute the `enable-elytron-se17.cli` script provided by EAP. Both scripts are necessary to configure the elytron adapter and remove the incompatible EAP subsystems. For more details, see this https://access.redhat.com/articles/6956863[Security Configuration Changes] article.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@andymunro andymunro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

@mposolda
Copy link
Contributor

@rmartinc @andymunro Thanks for the review and updates!

@mposolda mposolda merged commit c1afd3f into keycloak:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapters tests are failing for EAP and wildfly
3 participants