The getAttributes method in UserAttributeLDAPStorageMapper does not work for email or other UserModel properties #19352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork for email or other UserModel properties Closes keycloak#10412
mposolda
approved these changes
Mar 27, 2023
|
@ahus1 I took a look at the model tests and they just use the LDAP provider normally, so I think it's OK and just fixing the LDAP part is enough. But better if you double check it. 😄 |
|
@ahus1 Adding you as a reviewer to doublecheck if this method also affects new store and something should be changed there? Or is it not applicable in new store? |
ahus1
approved these changes
Mar 29, 2023
|
@ahus1 Cool, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10412
The
getAttributesmethod in the proxy for AlwaysReadValueFromLDAP is not returning the LDAP value for model properties (email, firstName, lastName,...). Therefore those attributes are read directly from the internal DB and the data is outdated. This PR makes thegetAttributesact likegetAttributeStream. Little test added.As commented in the issue #10412 the reported problem was already fixed by a previous commit but the root bug is still there.