Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not verify identity cookie when processing required actions #19459

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented Mar 31, 2023

Closes #17539

  • Only check if the user is logged in when requests have the authentication session cookie set. When set, it indicates the authentication is still happening.
  • Missing test coverage when there is no authentication session cookie but the identity cookie is still valid and maps to an existing user session. In this case, the server should continue with the required action without complaining about "user logged in" as there is no authentication/action yet happening.

@mposolda mposolda merged commit 6086201 into keycloak:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepup issue on "remember_me" authentication : alreadyLoggedIn
2 participants