Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new "Chrome for Testing" browser and driver. #22029

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

miquelsi
Copy link
Contributor

@miquelsi miquelsi commented Jul 27, 2023

Closes #22028

@miquelsi miquelsi requested a review from a team as a code owner July 27, 2023 10:21
.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Jul 27, 2023

1 flaky tests on run #8370 ↗︎

0 527 48 0 Flakiness 1

Details:

Merge fdae4c2 into 4dc929a...
Project: Keycloak Admin UI Commit: d63e2be3cd ℹ️
Status: Passed Duration: 18:14 💡
Started: Aug 3, 2023 10:41 AM Ended: Aug 3, 2023 11:00 AM
Flakiness  cypress/e2e/authentication_test.spec.ts • 1 flaky test • chrome

View Output Video

Test Artifacts
Authentication test > should add a condition Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

jonkoops
jonkoops previously approved these changes Jul 28, 2023
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me 👍

.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
@miquelsi miquelsi force-pushed the msimonma/chrome_testing branch 2 times, most recently from 2123d4d to 038afcb Compare August 2, 2023 09:00
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Aug 2, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginDifferentUserAfterDisabledUserThrownOut

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Expected LoginPage but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/#/)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:236)
...

Report flaky test

.github/actions/install-chrome/action.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as per @jonkoops's review

@ahus1 ahus1 merged commit 0dae40f into keycloak:main Aug 3, 2023
69 checks passed
@miquelsi miquelsi deleted the msimonma/chrome_testing branch August 4, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "Chrome for Testing" in GHA
3 participants