update subgroup storage layer to support pagination of subgroups #22374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
alice-wondered
added a commit
to alice-wondered/keycloak
that referenced
this pull request
Aug 17, 2023
… in use as well as scalability Modify Provider layer to allow for pagination on subgroups Modify Provider layer to allow for searching for subgroups by ID and Name Modify GroupModel to pass handling of subgroup lookups to the storage provider rather than performing the search on the model object Modify GroupsResource to take advantage of new storage functions, preventing loading of excess entities into memory from DB Modify GroupResource to allow for retrieval of all of the subgroups on an object, paginated, and sorted Modify construction of group hierarchy to load a vertical slice of the relevant information, i.e. only loading groups from leaf -> root without inclusion of siblings Changes to specific implementations of all of the above interfaces for the main storage providers Update all tests to show that there are no regressions in the changed behavior Add a count field to GroupRepresentation that lets a client know how many subgroups are on the group without having to retrieve them Modify relevant external resources to use new functionality on the storage layer (UserResource, RealmAdminResource, AccountRestService...) resolves keycloak#22374
alice-wondered
added a commit
to alice-wondered/keycloak
that referenced
this pull request
Aug 21, 2023
… in use as well as scalability Modify Provider layer to allow for pagination on subgroups Modify Provider layer to allow for searching for subgroups by ID and Name Modify GroupModel to pass handling of subgroup lookups to the storage provider rather than performing the search on the model object Modify GroupsResource to take advantage of new storage functions, preventing loading of excess entities into memory from DB Modify GroupResource to allow for retrieval of all of the subgroups on an object, paginated, and sorted Modify construction of group hierarchy to load a vertical slice of the relevant information, i.e. only loading groups from leaf -> root without inclusion of siblings Changes to specific implementations of all of the above interfaces for the main storage providers Update all tests to show that there are no regressions in the changed behavior Add a count field to GroupRepresentation that lets a client know how many subgroups are on the group without having to retrieve them Modify relevant external resources to use new functionality on the storage layer (UserResource, RealmAdminResource, AccountRestService...) resolves keycloak#22374
|
This PR is now outdated in favor of a consolidated branch with changes pertaining to all areas of this issue |
alice-wondered
added a commit
to alice-wondered/keycloak
that referenced
this pull request
Oct 24, 2023
… in use as well as scalability Modify Provider layer to allow for pagination on subgroups Modify Provider layer to allow for searching for subgroups by ID and Name Modify GroupModel to pass handling of subgroup lookups to the storage provider rather than performing the search on the model object Modify GroupsResource to take advantage of new storage functions, preventing loading of excess entities into memory from DB Modify GroupResource to allow for retrieval of all of the subgroups on an object, paginated, and sorted Modify construction of group hierarchy to load a vertical slice of the relevant information, i.e. only loading groups from leaf -> root without inclusion of siblings Changes to specific implementations of all of the above interfaces for the main storage providers Update all tests to show that there are no regressions in the changed behavior Add a count field to GroupRepresentation that lets a client know how many subgroups are on the group without having to retrieve them Modify relevant external resources to use new functionality on the storage layer (UserResource, RealmAdminResource, AccountRestService...) resolves keycloak#22374
alice-wondered
added a commit
to alice-wondered/keycloak
that referenced
this pull request
Oct 24, 2023
… in use as well as scalability Modify Provider layer to allow for pagination on subgroups Modify Provider layer to allow for searching for subgroups by ID and Name Modify GroupModel to pass handling of subgroup lookups to the storage provider rather than performing the search on the model object Modify GroupsResource to take advantage of new storage functions, preventing loading of excess entities into memory from DB Modify GroupResource to allow for retrieval of all of the subgroups on an object, paginated, and sorted Modify construction of group hierarchy to load a vertical slice of the relevant information, i.e. only loading groups from leaf -> root without inclusion of siblings Changes to specific implementations of all of the above interfaces for the main storage providers Update all tests to show that there are no regressions in the changed behavior Add a count field to GroupRepresentation that lets a client know how many subgroups are on the group without having to retrieve them Modify relevant external resources to use new functionality on the storage layer (UserResource, RealmAdminResource, AccountRestService...) resolves keycloak#22374
zwitter1
pushed a commit
to alice-wondered/keycloak
that referenced
this pull request
Nov 2, 2023
… in use as well as scalability Modify Provider layer to allow for pagination on subgroups Modify Provider layer to allow for searching for subgroups by ID and Name Modify GroupModel to pass handling of subgroup lookups to the storage provider rather than performing the search on the model object Modify GroupsResource to take advantage of new storage functions, preventing loading of excess entities into memory from DB Modify GroupResource to allow for retrieval of all of the subgroups on an object, paginated, and sorted Modify construction of group hierarchy to load a vertical slice of the relevant information, i.e. only loading groups from leaf -> root without inclusion of siblings Changes to specific implementations of all of the above interfaces for the main storage providers Update all tests to show that there are no regressions in the changed behavior Add a count field to GroupRepresentation that lets a client know how many subgroups are on the group without having to retrieve them Modify relevant external resources to use new functionality on the storage layer (UserResource, RealmAdminResource, AccountRestService...) resolves keycloak#22374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #22372