Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle GitHub logout properly #22463

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Handle GitHub logout properly #22463

merged 1 commit into from
Aug 28, 2023

Conversation

tondrusk
Copy link
Contributor

@tondrusk tondrusk commented Aug 15, 2023

This solution ensures that the logout process is on the correct URL while trying to click on the "Sign out" button.

Additionaly, the GitHub test cases lacked the profile info update method so this PR incorporates it to both test cases.

Add profile info update to GitHub login test cases

Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Aug 24, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.RegisterWithUserProfileTest#testEmailAsOptional

Keycloak CI - Forms IT (chrome)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...
java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:273)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:56)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:49)
	at jdk.internal.reflect.GeneratedMethodAccessor552.invoke(Unknown Source)
...

Report flaky test

org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az408-563', ip: '10.1.0.185', os.name: 'Linux', os.arch: 'amd64', os.version: '5.15.0-1041-azure', java.version: '17.0.8'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

@tondrusk
Copy link
Contributor Author

tondrusk commented Aug 25, 2023

Copy link
Contributor

@wojnarfilip wojnarfilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job Tomáš !

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as of @wojnarfilip's review

@ahus1 ahus1 merged commit e70ffd0 into keycloak:main Aug 28, 2023
66 checks passed
@tondrusk tondrusk deleted the KC-22461 branch October 4, 2023 12:34
tondrusk added a commit to tondrusk/keycloak that referenced this pull request Nov 21, 2023
Add profile info update to GitHub login test cases

Closes keycloak#22461

Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
(cherry picked from commit e70ffd0)
ahus1 pushed a commit that referenced this pull request Nov 27, 2023
Add profile info update to GitHub login test cases

Closes #22461

Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
(cherry picked from commit e70ffd0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect logout from GitHub
3 participants