-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle GitHub logout properly #22463
Conversation
Add profile info update to GitHub login test cases Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.forms.RegisterWithUserProfileTest#testEmailAsOptionalKeycloak CI - Forms IT (chrome)
org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodesKeycloak CI - Forms IT (firefox)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job Tomáš !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as of @wojnarfilip's review
Add profile info update to GitHub login test cases Closes keycloak#22461 Signed-off-by: Tomas Ondrusko <tondrusk@redhat.com> (cherry picked from commit e70ffd0)
This solution ensures that the logout process is on the correct URL while trying to click on the "Sign out" button.
Additionaly, the GitHub test cases lacked the profile info update method so this PR incorporates it to both test cases.