Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing build time dependencies from the runtime #22501

Merged
merged 1 commit into from
Aug 21, 2023
Merged

removing build time dependencies from the runtime #22501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions operator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,10 @@

<dependencies>
<!-- Fabric8 -->
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>crd-generator-api</artifactId>
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
<artifactId>crd-generator-apt</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this dependency, actually?

Copy link
Contributor Author

@shawkins shawkins Aug 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least it's still transitively bringing in the sundrio dependencies. I'm not sure historically why crd-generator-apt was needed.

It looks like instead of the apt dependency we could separtely use:
generator-annotations (for the Required annotation)
crd-generator-api (for the SchemaSwap annotation - it's confusing why this is not in generator-annotations)
builder-annotations (but there's no managed version of this provided by the poms we're currently importing)

Since it looks like this can be at the provided scope, I'd be in favor of leaving it as is unless you think it could be introducing other problems.

Any thoughts on quarkus-operator-sdk-bundle-generator?

<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.fabric8</groupId>
Expand Down Expand Up @@ -174,6 +171,11 @@
<goals>
<goal>build</goal>
</goals>
<configuration>
<properties>
<quarkus.package.filter-optional-dependencies>true</quarkus.package.filter-optional-dependencies>
</properties>
</configuration>
vmuzikar marked this conversation as resolved.
Show resolved Hide resolved
</execution>
</executions>
</plugin>
Expand Down
Loading