Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Italian translation for keycloak.v2 theme for account section #22592

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Added Italian translation for keycloak.v2 theme for account section #22592

merged 6 commits into from
Sep 1, 2023

Conversation

DeltaFox0018
Copy link
Contributor

Added Italian translation for keycloak.v2 theme for account section

Closes #22552

@DeltaFox0018 DeltaFox0018 requested a review from a team as a code owner August 21, 2023 19:02
@DeltaFox0018
Copy link
Contributor Author

DeltaFox0018 commented Aug 21, 2023 •
edited
Loading

I created this pull request to add the Italian translation of some fields that are missing

@jonkoops
Copy link
Contributor

Hi @DeltaFox0018, it's customary to have another native speaker review the work to ensure it is correct. Do you happen to know someone who could perform a review? Feel free to assign them as a reviewer of this PR.

@DeltaFox0018
Copy link
Contributor Author

@jonkoops
Yes now I ask someone to give a revision to the translation

@DeltaFox0018 DeltaFox0018 marked this pull request as draft August 22, 2023 13:48
@DeltaFox0018 DeltaFox0018 marked this pull request as ready for review August 22, 2023 13:51
volpe03
volpe03 approved these changes Aug 22, 2023
View reviewed changes
Copy link

@volpe03 volpe03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translation is correct

jonkoops
jonkoops previously approved these changes Aug 22, 2023
View reviewed changes
@jonkoops jonkoops enabled auto-merge (squash) August 22, 2023 15:09
@jonkoops
Copy link
Contributor

Thanks for your contribution @DeltaFox0018! I've set the PR to merge automatically when CI checks succeed. Also thanks @volpe03 for the review.

@ghost ghost added the flaky-test label Aug 28, 2023
This was referenced Aug 28, 2023
Closed
Closed
@ghost ghost mentioned this pull request Aug 28, 2023
Closed
@DeltaFox0018
Copy link
Contributor Author

Hi, why was it tagged with flky-test?

auto-merge was automatically disabled August 31, 2023 21:13

Head branch was pushed to by a user without write access

@DeltaFox0018 DeltaFox0018 marked this pull request as draft August 31, 2023 21:13
DeltaFox0018
DeltaFox0018 commented Aug 31, 2023
View reviewed changes
Copy link
Contributor Author

@DeltaFox0018 DeltaFox0018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add missing translation in italian base theme

@DeltaFox0018 DeltaFox0018 marked this pull request as ready for review August 31, 2023 21:14
@ahus1 ahus1 self-assigned this Sep 1, 2023
This was referenced Sep 1, 2023
Closed
Closed
@jonkoops
Copy link
Contributor

jonkoops commented Sep 1, 2023

Hi, why was it tagged with flky-test?

Seems like a fluke on CI, since this PR doesn't change any logic we can safely ignore it.

@jonkoops jonkoops enabled auto-merge (squash) September 1, 2023 11:17
@jonkoops
Copy link
Contributor

jonkoops commented Sep 1, 2023

I've set the PR to merge automatically once a maintainer approves it. Thanks for your contribution @DeltaFox0018 and @volpe03.

@jonkoops jonkoops merged commit 3d45a80 into keycloak:main Sep 1, 2023
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkoops jonkoops jonkoops approved these changes

@ahus1 ahus1 ahus1 approved these changes

@volpe03 volpe03 volpe03 approved these changes

Assignees

@ahus1 ahus1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more translations for the Italian language
4 participants
@DeltaFox0018 @jonkoops @ahus1 @volpe03