Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex support in 'Condition - User attribute' execution #23169

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add regex support in 'Condition - User attribute' execution #23169

merged 1 commit into from
Sep 13, 2023

Conversation

cgeorgilakis
Copy link
Contributor

Closes #265

@cgeorgilakis cgeorgilakis requested review from a team as code owners September 12, 2023 10:33
@cgeorgilakis cgeorgilakis requested a review from a team September 12, 2023 10:33
@cgeorgilakis cgeorgilakis requested a review from a team as a code owner September 12, 2023 10:33
This was referenced Sep 12, 2023
Closed
Closed
Closed
Closed
mposolda
mposolda approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgeorgilakis LGTM, Thanks for adding this!

@mposolda mposolda merged commit 0044472 into keycloak:main Sep 13, 2023
66 checks passed
@mposolda mposolda linked an issue Sep 13, 2023 that may be closed by this pull request
Add regex support in 'Condition - User attribute' execution #23194
Closed
@mposolda
Copy link
Contributor

@cgeorgilakis I figured wrong issue was linked to this, so I've created new issue #23194 and linked with this PR

@cgeorgilakis
Copy link
Contributor Author

Thanks @mposolda.
I have create the issue in wrong place.

My description was (if you want to change the issue description) :

'Condition - User attribute' execution does not allow searching user attribute with regex.
We will add boolean regex. If user select regex, 'Condition - User attribute' execution search will be based on regular expression. default regex value will be false (keeping same behaviour as current Keycloak).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mposolda mposolda mposolda approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add regex support in 'Condition - User attribute' execution
2 participants
@cgeorgilakis @mposolda