Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes.adoc for guides to share common attributes #24519

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Nov 3, 2023

Adding support for attributes.adoc to set shared attributes throughout guides, and use {project_name} in new guides like we are doing for the old documentation format.

Updated a few places in the old docs where we didn't use {project_name}

PR for the website to support loading attributes from attributes.adoc when parsing guide attributes (titles/descriptions) here: keycloak/keycloak-web#429

docs/guides/attributes.adoc Outdated Show resolved Hide resolved
@ghost ghost added the flaky-test label Nov 3, 2023
@stianst stianst force-pushed the guides-attributes branch 2 times, most recently from 0a4e787 to 6f4b9be Compare November 6, 2023 09:04
@stianst stianst marked this pull request as ready for review November 6, 2023 09:04
@stianst stianst requested review from a team as code owners November 6, 2023 09:04
@ghost ghost added team/cloud-native labels Nov 6, 2023
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes, they look good to me. I saw that some "Keycloak CR" occurrences weren't replaced, I assume this was done on purpose.

@ahus1 ahus1 merged commit 565bc7d into keycloak:main Nov 8, 2023
67 checks passed
@stianst stianst deleted the guides-attributes branch January 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants