Switch locale #24736
Merged
Switch locale #24736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
1 flaky test on run #10211 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Client registration policies tab > Authenticated client policies subtab > add authenticated client registration policy |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #24736 ↗︎
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
jonkoops
requested changes
Nov 14, 2023
This was referenced Nov 14, 2023
jonkoops
reviewed
Nov 14, 2023
| @@ -12,6 +12,14 @@ const DEFAULT_LOCALE = "en"; | |||
| // that we can have a proper type-safe translation function. | |||
| export type TFuncKey = any; | |||
|
|
|||
| export const keycloakLanguageDetector: LanguageDetectorModule = { | |||
There was a problem hiding this comment.
Oh cool, I wasn't aware this is a feature! Perhaps we should implement this the same way in the Admin Console.
jonkoops
previously approved these changes
Nov 14, 2023
fixes: keycloak#24082 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
ghost
reviewed
Nov 21, 2023
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.account.AccountRestServiceTest#updateConsentForClientWithPutKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClientWithPutKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) org.keycloak.testsuite.account.AccountRestServiceTest#createConsentForClientKeycloak CI - Java Distribution IT (windows-latest - temurin - 19) |
jonkoops
previously approved these changes
Nov 21, 2023
jonkoops
force-pushed
the
issue-24082
branch
from
c2d19e1
to
a10db1f
Compare
This was referenced Nov 27, 2023
Closed
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
jonkoops
approved these changes
Dec 7, 2023
ShefeeqPM
pushed a commit
to ShefeeqPM/keycloak
that referenced
this pull request
Jan 27, 2024
* Switch locale fixes: keycloak#24082 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * PR comments Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #24082
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com