Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keycloak-js] Expose processCallback, parseCallback and createPromise to custom adapters #25736

Closed

Conversation

javialon26
Copy link

Possible solution to issue #10174.

I'm adding a new way to create adapters, which is a factory function (receive as parameters all the required internal KC methods like processCallback, parseCallback, createPromise, and KC instance) and must return a KeycloakAdapter object.

This is a preliminary PR, we need to work on tests, documentation, etc. but the idea is pretty clear.

@javialon26 javialon26 requested a review from a team as a code owner December 20, 2023 16:45
@ghost ghost added the team/ui label Dec 20, 2023
@jonkoops
Copy link
Contributor

Thanks for the PR, but we do not want to expose createPromise() as a public API. Keycloak JS should be refactored internally first to move towards standard Promise-based code.

@jonkoops jonkoops closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants