Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Security Key with Passkey in WebAuthn UIs and their documents #27151

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Replace Security Key with Passkey in WebAuthn UIs and their documents #27151

merged 1 commit into from
Feb 29, 2024

Conversation

tnorimat
Copy link
Contributor

closes #27147

@tnorimat tnorimat requested review from a team as code owners February 20, 2024 02:20
@cypress Cypress
Copy link

cypress bot commented Feb 20, 2024

Passing run #11099 ↗︎

0 553 53 0 Flakiness 0

Details:

Merge 6edd1c8c191683579f43bd2f896c8b680a28beb7 into 870befa...
Project: Keycloak Admin UI Commit: f99c7171fa ℹ️
Status: Passed Duration: 07:58 💡
Started: Feb 20, 2024 2:27 AM Ended: Feb 20, 2024 2:35 AM

Review all test suite changes for PR #27151 ↗︎

This was referenced Feb 20, 2024
Open
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Feb 20, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.ApplicationsTest#toggleApplicationDetailsTest

Keycloak CI - Account Console IT (chrome)

org.openqa.selenium.TimeoutException: 
timeout: Timed out receiving message from renderer: 3.953
  (Session info: chrome-headless-shell=121.0.6167.160)
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1435-783', ip: '10.1.0.111', os.name: 'Linux', os.arch: 'amd64', os.version: '6.2.0-1019-azure', java.version: '17.0.10'
...

Report flaky test

@mposolda mposolda self-assigned this Feb 20, 2024
mposolda
mposolda previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat Thanks!

@mposolda
Copy link
Contributor

@keycloak/ui-maintainers Anyone available to review UI changes in this PR please?

jonkoops
jonkoops requested changes Feb 26, 2024
View reviewed changes
js/apps/account-ui/maven-resources/theme/keycloak.v3/account/messages/messages_en.properties Outdated Show resolved Hide resolved
docs/documentation/server_admin/topics/account.adoc Outdated Show resolved Hide resolved
docs/documentation/server_admin/topics/account.adoc Outdated Show resolved Hide resolved
docs/documentation/server_admin/topics/account.adoc Outdated Show resolved Hide resolved
docs/documentation/server_admin/topics/account.adoc Outdated Show resolved Hide resolved
...her/webauthn/src/test/java/org/keycloak/testsuite/webauthn/WebAuthnRegisterAndLoginTest.java Outdated Show resolved Hide resolved
...er/webauthn/src/test/java/org/keycloak/testsuite/webauthn/account/WebAuthnSigningInTest.java Outdated Show resolved Hide resolved
...er/webauthn/src/test/java/org/keycloak/testsuite/webauthn/account/WebAuthnSigningInTest.java Outdated Show resolved Hide resolved
themes/src/main/resources/theme/base/login/messages/messages_en.properties Outdated Show resolved Hide resolved
themes/src/main/resources/theme/keycloak.v2/account/messages/messages_en.properties Outdated Show resolved Hide resolved
@tnorimat tnorimat force-pushed the ISSUE-27147-Security-Key-to-Passkey branch from 6edd1c8 to 6c56b24 Compare February 27, 2024 04:23
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Feb 27, 2024
Closed
@tnorimat tnorimat force-pushed the ISSUE-27147-Security-Key-to-Passkey branch from 6c56b24 to 7dddd3c Compare February 27, 2024 07:00
@tnorimat
Copy link
Contributor Author

@jonkoops Thank you for your review comments. I incorporated all of your review comments into the PR. Could you check them?

@tnorimat tnorimat force-pushed the ISSUE-27147-Security-Key-to-Passkey branch from 7dddd3c to dda6da4 Compare February 27, 2024 07:20
This was referenced Feb 27, 2024
Open
Closed
jonkoops
jonkoops previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mposolda
mposolda previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat @jonkoops Thanks for the updates and review! I hope to merge once tests are OK

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Feb 28, 2024
Closed
@mposolda
Copy link
Contributor

@tnorimat Could you please rebase? That should help with fixing the test failure in FIPS tests (it was fixed today in Keycloak main).

@tnorimat
Replace Security Key with Passkey in WebAuthn UIs and their documents
163fb00 
closes keycloak#27147

Signed-off-by: Takashi Norimatsu <takashi.norimatsu.ws@hitachi.com>
@tnorimat tnorimat dismissed stale reviews from mposolda and jonkoops via 163fb00 February 29, 2024 01:02
@tnorimat tnorimat force-pushed the ISSUE-27147-Security-Key-to-Passkey branch from dda6da4 to 163fb00 Compare February 29, 2024 01:02
@tnorimat
Copy link
Contributor Author

@mposolda I rebased the PR on the main branch.

ahus1
ahus1 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving after @mposolda's review and rebase

@ahus1 ahus1 self-assigned this Feb 29, 2024
@ahus1 ahus1 requested a review from jonkoops February 29, 2024 07:39
@ahus1
Copy link
Contributor

ahus1 commented Feb 29, 2024

@jonkoops - could you please re-approve after the rebase? Thanks!

@ahus1 ahus1 enabled auto-merge (rebase) February 29, 2024 07:40
mposolda
mposolda approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnorimat Thanks for the rebase!

@mposolda mposolda merged commit 3db04d8 into keycloak:main Feb 29, 2024
73 checks passed
@tnorimat tnorimat deleted the ISSUE-27147-Security-Key-to-Passkey branch March 2, 2024 04:08
@Lamak121 Lamak121 mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot left review comments

@mposolda mposolda mposolda approved these changes

@ahus1 ahus1 ahus1 approved these changes

@jonkoops jonkoops Awaiting requested review from jonkoops

Assignees

@mposolda mposolda

@ahus1 ahus1

Labels
area/authentication/webauthn flaky-test team/cloud-native team/core-clients team/core-iam team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace "Security Key" with "Passkey" in WebAuthn UIs and their documents
4 participants
@tnorimat @mposolda @ahus1 @jonkoops