Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Quarkus 3.7.4 #27231

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Upgrade to Quarkus 3.7.4 #27231

merged 1 commit into from
Feb 22, 2024

Conversation

vmuzikar
Copy link
Contributor

Closes #27226

@vmuzikar
Upgrade to Quarkus 3.7.4
9583f93 
Closes keycloak#27226

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
@vmuzikar vmuzikar requested a review from a team as a code owner February 22, 2024 11:06
mabartos
mabartos approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmuzikar LGTM

AFAIK, the platform already contains 3.8.0.CR1, so we should try it, right?

https://mvnrepository.com/artifact/io.quarkus.platform/quarkus-bom/3.8.0.CR1

@vmuzikar
Copy link
Contributor Author

@mabartos Thanks for the review! AFAIK, 3.8.0.CR1 is corresponding to 3.7.3. Whereas 3.7.4 will be corresponding to 3.8.0.

@mabartos
Copy link
Contributor

@vramik Ahh, nice :)

@vmuzikar vmuzikar enabled auto-merge (squash) February 22, 2024 11:26
This was referenced Feb 22, 2024
Open
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Feb 22, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserLoginTest#changeLocaleOnX509InfoPage

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserLoginTest#loginDuplicateUsersNotAllowed

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserLoginTest#loginAsUserFromCertSerialNumberMappedToUserAttribute

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

@vmuzikar vmuzikar merged commit 35537d6 into keycloak:main Feb 22, 2024
68 checks passed
@vmuzikar vmuzikar deleted the quarkus-374 branch February 22, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot left review comments

@abstractj abstractj abstractj approved these changes

@mabartos mabartos mabartos approved these changes

Assignees
No one assigned
Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Quarkus 3.7.4
3 participants
@vmuzikar @mabartos @abstractj