Check email and username for duplicated if isLoginWithEmailAllowed #27408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#27297 Signed-off-by: rmartinc <rmartinc@redhat.com>
pedroigor
reviewed
Mar 1, 2024
services/src/main/java/org/keycloak/userprofile/validator/DuplicateUsernameValidator.java
Show resolved
Hide resolved
pedroigor
approved these changes
Mar 1, 2024
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27297
Email and username validators check duplicates in the other attribute if
isLoginWithEmailAllowedis enabled. The duplicated username validator was working incorrectly, fixed now. I decided to add the duplicated validators to the ADMIN_API too. The user endpoints try to return the same errors as before (there are very little differences but more or less the same). Tests added to two contexts: admin api and update profile action.