Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load server info before rendering rest of application #27783

Merged
merged 1 commit into from Mar 13, 2024
Merged

Load server info before rendering rest of application #27783

merged 1 commit into from Mar 13, 2024

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Mar 11, 2024 •
edited

Closes #27840

@jonkoops
Load server info before rendering rest of application
d414a81 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops jonkoops self-assigned this Mar 11, 2024
@sschu sschu mentioned this pull request Mar 13, 2024
Closed
2 tasks
@sschu
Copy link
Contributor

sschu commented Mar 13, 2024

There you go @jonkoops : #27840. I can also confirm this fix works.

@jonkoops
Copy link
Contributor Author

Awesome, thanks @sschu!

@jonkoops jonkoops marked this pull request as ready for review March 13, 2024 11:27
@jonkoops jonkoops requested a review from a team as a code owner March 13, 2024 11:27
@jonkoops jonkoops enabled auto-merge (squash) March 13, 2024 11:32
agagancarczyk
agagancarczyk approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@agagancarczyk agagancarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonkoops jonkoops merged commit 7b755e0 into keycloak:main Mar 13, 2024
52 checks passed
@jonkoops jonkoops deleted the load-server-info-first branch March 13, 2024 12:41
jonkoops added a commit to jonkoops/keycloak that referenced this pull request Mar 13, 2024
@jonkoops
Load server info before rendering rest of application (keycloak#27783)
64ed544 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 7b755e0)
jonkoops added a commit to jonkoops/keycloak that referenced this pull request Mar 13, 2024
@jonkoops
Load server info before rendering rest of application (keycloak#27783)
07624d1 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 7b755e0)
jonkoops added a commit that referenced this pull request Mar 13, 2024
@jonkoops
Load server info before rendering rest of application (#27783) (#27857)
d61c056 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 7b755e0)
jonkoops added a commit that referenced this pull request Mar 13, 2024
@jonkoops
Load server info before rendering rest of application (#27783) (#27858)
22fc530 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 7b755e0)
markbanierink pushed a commit to markbanierink/keycloak that referenced this pull request Mar 18, 2024
@jonkoops @markbanierink
Load server info before rendering rest of application (keycloak#27783)
4df2e8d 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this pull request Mar 22, 2024
@jonkoops @ahus1
Load server info before rendering rest of application (keycloak#27783)
567d07b 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Assignees

@jonkoops jonkoops

Labels
team/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition loading serverinfo in admin console
3 participants
@jonkoops @sschu @agagancarczyk