Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make general cache options runtime #28542

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Apr 9, 2024

Closes #27549

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserLoginTest#changeLocaleOnX509InfoPage

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserLoginTest#loginDuplicateUsersNotAllowed

Keycloak CI - Java Distribution IT (windows-latest - temurin - 19)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

Closes keycloak#27549

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @mabartos this will help with import / export confusion around caching as well.

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod

Keycloak CI - Base IT (1)

java.lang.AssertionError: identityProviders instance count expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.keycloak.testsuite.admin.IdentityProviderTest.testSamlImport(IdentityProviderTest.java:761)
...

Report flaky test

@mabartos
Copy link
Contributor Author

mabartos commented Apr 9, 2024

@shawkins Thanks, Steven!

@ahus1 @vmuzikar Do you want to review it as well?

@ahus1
Copy link
Contributor

ahus1 commented Apr 10, 2024

@mabartos - LGTM, I trust our tests.

@mabartos mabartos enabled auto-merge (squash) April 10, 2024 16:46
@mabartos
Copy link
Contributor Author

@ahus1 Thanks for the review

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabartos High level LGTM, approving based on review from @shawkins.

@mabartos mabartos merged commit a3669a6 into keycloak:main Apr 12, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make general cache options runtime
4 participants