-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make general cache options runtime #28542
Conversation
318c142
to
e5d4331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.x509.X509BrowserLoginTest#changeLocaleOnX509InfoPageKeycloak CI - Java Distribution IT (windows-latest - temurin - 19)
org.keycloak.testsuite.x509.X509BrowserLoginTest#loginDuplicateUsersNotAllowedKeycloak CI - Java Distribution IT (windows-latest - temurin - 19)
|
Closes keycloak#27549 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @mabartos this will help with import / export confusion around caching as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.admin.IdentityProviderTest#testSamlImportWithAnyEncryptionMethod
|
@mabartos - LGTM, I trust our tests. |
@ahus1 Thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #27549