New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code from model/infinispan module #29138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.BrokerLinkAndTokenExchangeTest#testExternalExchangeCreateNewUserUsingMappers
org.keycloak.testsuite.adapter.servlet.BrokerLinkAndTokenExchangeTest#testExternalExchange
org.keycloak.testsuite.adapter.servlet.BrokerLinkAndTokenExchangeTest#testAccountLinkNoTokenStore
org.keycloak.testsuite.client.ClientTypesTest#testUpdateClientWithClientType
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testExchangeWithDynamicScopesEnabled
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testClientExchange
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testIntrospectTokenAfterImpersonation
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testPublicClientNotAllowed
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testExchangeUsingServiceAccount
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testImpersonation
org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testImpersonationUsingPublicClient
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this cleanup. I'm a bit on the fence about removing CLIENT_REMOVED_SESSION_EVENT. I agree it doesn't do anything at the moment, so I'd be ok to go with this change.
The is one method name that should be changed, see below. It is kind of a nitpick, still I want to be safe to not have it being misused in the future.
@@ -884,27 +876,14 @@ private UserSessionEntity createUserSessionEntityInstance(UserSessionModel userS | |||
|
|||
|
|||
private AuthenticatedClientSessionAdapter importClientSession(UserSessionAdapter sessionToImportInto, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the "offline" boolean flag, the name of the method should change to "importOfflineClientSession" to avoid people using this method in a wrong place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Updated!
Closes keycloak#29137 Signed-off-by: Pedro Ruivo <pruivo@redhat.com>
Closes #29137