Do not manage brokers through the Organization API #29269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keycloak-github-bot
bot
added
team/cloud-native
team/core-clients
team/core-iam
flaky-test
labels
This was referenced May 3, 2024
Closed
Closed
pedroigor
force-pushed
the
issue-29268
branch
2 times, most recently
from
1c7ca53
to
85d65e5
Compare
sguilhen
reviewed
May 6, 2024
|
|
||
| if (existing == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why return here? If you are importing an IDP, don't you want to check if the representation matches an org (potentially) and one of its domain regardless of it existing already?
There was a problem hiding this comment.
Makes sense. I did not consider importing as we are not yet supporting import/export. Changed and added a test to cover this scenario.
| return Response.status(Status.BAD_REQUEST).build(); | ||
| } | ||
| if (!isOrganizationBroker(broker)) { | ||
| throw ErrorResponse.error("Identity provider not found with the given alias", Status.NOT_FOUND); |
There was a problem hiding this comment.
Shouldn't the message indicate that no provider with the specified alias is currently bound to the org? If you prefer we can create a follow up issue to revisit all messages returned from endpoints.
pedroigor
force-pushed
the
issue-29268
branch
2 times, most recently
from
d510c71
to
ac3d7a3
Compare
Closes keycloak#29268 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
sguilhen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29268
Depends on for #29064.