Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update governance model around changes in maintainership #29292

Merged
merged 3 commits into from
May 22, 2024

Conversation

stianst
Copy link
Contributor

@stianst stianst commented May 6, 2024

Signed-off-by: stianst stianst@gmail.com

Signed-off-by: stianst <stianst@gmail.com>
vmuzikar
vmuzikar previously approved these changes May 6, 2024
jonkoops
jonkoops previously approved these changes May 6, 2024
mhajas
mhajas previously approved these changes May 6, 2024
hmlnarik
hmlnarik previously approved these changes May 6, 2024
@sschu
Copy link
Contributor

sschu commented May 6, 2024

I am wondering if January and July are the best months for this. Personally, I am typically on holiday most of July due to school vacation. Something like March/September would work better for me.

Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the same minor concern as Sebastian mentioned :)

GOVERNANCE.md Outdated Show resolved Hide resolved
@stianst stianst dismissed stale reviews from hmlnarik, mhajas, jonkoops, and vmuzikar via 0818f2e May 6, 2024 09:43
@stianst
Copy link
Contributor Author

stianst commented May 6, 2024

I am wondering if January and July are the best months for this. Personally, I am typically on holiday most of July due to school vacation. Something like March/September would work better for me.

Updated to March/September

@stianst stianst marked this pull request as ready for review May 6, 2024 09:43
@stianst stianst requested a review from a team as a code owner May 6, 2024 09:43
mhajas
mhajas previously approved these changes May 6, 2024
vmuzikar
vmuzikar previously approved these changes May 6, 2024
Copy link
Contributor

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hmlnarik
hmlnarik previously approved these changes May 6, 2024
GOVERNANCE.md Outdated Show resolved Hide resolved
ahus1
ahus1 previously approved these changes May 6, 2024
mposolda
mposolda previously approved these changes May 6, 2024
pedroigor
pedroigor previously approved these changes May 13, 2024
Co-authored-by: Stan Silvert <ssilvert@redhat.com>
@stianst stianst merged commit ceb7077 into keycloak:main May 22, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet