Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the organization authentication flow #29371

Merged
merged 1 commit into from
May 9, 2024

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented May 7, 2024

I can create an issue for each of these points, but in general, they are polishing and adding more tests to the organization authentication flow. It also helps to use the CLI (WIP https://gist.github.com/pedroigor/5696da1f32370f32714fc61844fedec8) to start playground with organizations.

  • Today, we are always redirecting users (regardless if they exist or not) to the broker associated with the org. Including when there is a single one. This change set makes sure users are automatically redirected only when:
    • If an existing user and already linked to the broker associated to the org
    • If a new user and there is a broker that maps to the email domain
    • If a user does not exist, the email maps to an org domain, and there are public brokers in the org, the registration link is hidden so that the user can register through the broker instead. A message is also shown.
    • Tests added for all those cases
  • Fixes NPE when creating resources using the CLI where some optional data is not sent. It will help with working with the CLI
  • Make sure the Sign in with message is not shown on login pages if there are no brokers to choose
  • Not yet supporting internationalization

Closes keycloak#29416
Closes keycloak#29417
Closes keycloak#29418

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Copy link
Contributor

@ssilvert ssilvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedroigor pedroigor merged commit 77b5827 into keycloak:main May 9, 2024
67 checks passed
@pedroigor pedroigor deleted the org-auth branch May 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants