Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure organization groups can not be managed but when managing an organization #29424

Merged
merged 1 commit into from
May 11, 2024
Merged

Make sure organization groups can not be managed but when managing an organization #29424

merged 1 commit into from
May 11, 2024

Conversation

pedroigor
Copy link
Contributor

@pedroigor pedroigor commented May 9, 2024 •
edited

Closes #29431

  • Leveraging provider events to introduce validations when managing organization groups
  • Introduces additional events to groups that might be also useful for regular realms
  • Keeping the validation within the organization provider rather than spread in multiple places

This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
@pedroigor pedroigor force-pushed the org-group-guards branch 3 times, most recently from 4a4bfc6 to 3496e0e Compare May 9, 2024 22:15
@pedroigor pedroigor changed the title group guards Make sure organization groups can not be managed but when managing an organization May 9, 2024
@pedroigor pedroigor marked this pull request as ready for review May 9, 2024 22:48
@pedroigor pedroigor requested review from a team as code owners May 9, 2024 22:48
@pedroigor pedroigor force-pushed the org-group-guards branch 2 times, most recently from 0eadffe to 31494a5 Compare May 10, 2024 12:05
martin-kanis
martin-kanis approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@martin-kanis martin-kanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedroigor
Make sure organization groups can not be managed but when managing an…
e280e15 
… organization

Closes keycloak#29431

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
ssilvert
ssilvert approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@ssilvert ssilvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the other two reviews.

@pedroigor pedroigor merged commit b50d481 into keycloak:main May 11, 2024
67 checks passed
@pedroigor pedroigor mentioned this pull request May 13, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguilhen sguilhen sguilhen approved these changes

@ssilvert ssilvert ssilvert approved these changes

@martin-kanis martin-kanis martin-kanis approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure organization groups can not be managed but when managing an organization
4 participants
@pedroigor @sguilhen @ssilvert @martin-kanis