-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds handling for a KC_CLI_PASSWORD env variable #29430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...on/client-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseAuthOptionsCmd.java
Outdated
Show resolved
Hide resolved
...ent-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseConfigCredentialsCmd.java
Outdated
Show resolved
Hide resolved
...on/client-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseAuthOptionsCmd.java
Outdated
Show resolved
Hide resolved
@vmuzikar updated the punctuation / typo. I'm now thinking this is probably too narrow in scope. Users would expect the same behavior for the client secret, store pass, etc. Does it seem ok to expend the effort for all of these? |
Works for me. |
1e26c33
to
fbeda94
Compare
@vmuzikar updated to all kcadm sensitive options, which covers some of kcreg as well. Added a few mentions in the docs. Can also add a v26 release note if desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @shawkins.
closes: keycloak#21961 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
closes: #21961
Went the route of picocli defaults for this. We could consider adding a general default handler, but option keys for the "secrets" don't seem consistent.
The other possible "secret" env variables (not addressed in this pr) include: