Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures after methods annotated with @DisableFeature #29448

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix test failures after methods annotated with @DisableFeature #29448

merged 1 commit into from
May 13, 2024

Conversation

graziang
Copy link
Contributor

Checks the state of the class to detect if the feature should be enabled or disabled after method execution.

Closes #29246
Closes #29247
Closes #29248
Closes #29249
Closes #29250
Closes #29251
Closes #29252
Closes #29253

@graziang
Fix test failures after @DisableFeature
d806711 
Closes keycloak#29253

Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
@graziang graziang requested review from a team as code owners May 10, 2024 13:00
@graziang graziang requested a review from rmartinc May 10, 2024 13:20
rmartinc
rmartinc approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graziang! LGTM!

ahus1
ahus1 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @rmartinc's review. Thank you for this fix!

@ahus1 ahus1 merged commit d735668 into keycloak:main May 13, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

@rmartinc rmartinc rmartinc approved these changes

Assignees
No one assigned
Labels
team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testPublicClientNotAllowed Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testIntrospectTokenAfterImpersonation Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testClientExchange Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testExchangeWithDynamicScopesEnabled Flaky test: org.keycloak.testsuite.client.ClientTypesTest#testUpdateClientWithClientType
Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testExchangeUsingServiceAccount Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testImpersonation Flaky test: org.keycloak.testsuite.oauth.ClientTokenExchangeTest#testImpersonationUsingPublicClient
3 participants
@graziang @ahus1 @rmartinc