Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEYCLOAK-4784 Cannot build project with -Dproduct #4071

Merged
merged 1 commit into from Apr 26, 2017

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Apr 25, 2017

No description provided.

@stianst
Copy link
Contributor Author

stianst commented Apr 25, 2017

@sebastienblanc I don't see any reason why spring-boot has to be updated to 9.3 adapter. It needs to work on all Jetty versions so the version shouldn't matter. Since we don't push 9.3 in product atm it's also problematic. Do you see any problem with reverting it to 9.2 as here?

@sebastienblanc
Copy link
Contributor

This update was probably made because for Spring Boot the default Jetty is now 9.3 and using 9.2 needs some tweaks (https://docs.spring.io/spring-boot/docs/current/reference/html/howto-embedded-servlet-containers.html#howto-use-jetty-9.2-maven).
But in the short term I don't think it's a problem to revert.

@stianst
Copy link
Contributor Author

stianst commented Apr 25, 2017

Oki, maybe we can go the other way and include Jetty 9.3 in product be an issue. Shouldn't be an issue. I'll look into that.

@stianst
Copy link
Contributor Author

stianst commented Apr 26, 2017

@martin-kanis would it be a problem if we include Jetty 9.3 in product builds?

@martin-kanis
Copy link
Contributor

@stianst we can include it

@stianst stianst merged commit eedb40b into keycloak:master Apr 26, 2017
@stianst stianst deleted the KEYCLOAK-4784 branch June 30, 2017 12:34
123445666 pushed a commit to 123445666/keycloak that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants