[KEYCLOAK-2538] - groups pagination and group search #4710
Conversation
…d mockito dependency
…quillian Tests, delete mockito from poms, fix groups sorting when get result from cache
…com/guitaro/keycloak into feature/group-search-and-pagination
- Fix group creation bug - Add pagination on default groups tab - Add pagination on group membership user page - Fix cache invalidations
levyndot
changed the title
|
The pages number on each lists is not updated when a search is done. I'm fixing it right now. |
|
It's ok for pages number update. |
|
Did you think that this PR can be released before February ? |
|
Due to feature freeze for Keycloak 3.x we're not able to accept this contribution at the moment. We would also really need some tests added here for the admin console as the previous PR for this was quite broken if I remember correctly. If the PR is updated and tests added we should be able to review and include it for the first Keycloak 4.x release which should be some time in February. |
|
Thanks @stianst for this answer. |
|
Hi, I'm coming for news. Can we have any state on test progress for this feature ? Thanks. |
|
@patriot1burke, @stianst, any news please about this feature ? Thanks |
|
@mposolda can you take a look at this please? |
There was a problem hiding this comment.
@guitaro Thanks for the PR and sorry it took so long to review :( Overally it looks very good. I have few points:
-
Will be good to squash the commits to contain just 1 commit in the PR instead of 14 commits and ensure it is rebases/cherry-picked on top of latest master. We strongly prefer rebase/cherry-pick instead of merging due the cleaner git history. I see there are conflicts in files GroupsResource and UsersResource, but not sure, if you rather don't want to remove any changes from those files entirely (as I see that your PR changes just imports).
-
Is it possible that you add some automated tests to the admin console UI tests and re-check that your changes didn't break existing tests? See: https://github.com/keycloak/keycloak/blob/master/testsuite/integration-arquillian/HOW-TO-RUN.md#admin-console-ui-tests
|
Hi @mposolda, Thanks for your review ! I'm working on the points that you described. Coming soon. |
KEYCLOAK 2538 - UI group pagination - fix duplicate result for search + sort result KEYCLOAK 2538 - UI group pagination - TU + some code improvement + add mockito dependency KEYCLOAK 2538 - UI group pagination - Remove junit mocked TUs, add arquillian Tests, delete mockito from poms, fix groups sorting when get result from cache KEYCLOAK 2538 - UI group pagination : - Fix group creation bug - Add pagination on default groups tab - Add pagination on group membership user page - Fix cache invalidations KEYCLOAK 2538 - UI group pagination - update pages number on group search KEYCLOAK 2538 - UI group pagination - Remove GroupListLoader KEYCLOAK 2538 - compilation failed KEYCLOAK 2538 - UI group pagination
…ion' into feature/group-search-and-pagination # Conflicts: # server-spi-private/src/main/java/org/keycloak/models/utils/ModelToRepresentation.java # services/src/main/java/org/keycloak/services/resources/admin/UsersResource.java # themes/src/main/resources/theme/base/admin/resources/js/controllers/groups.js # themes/src/main/resources/theme/base/admin/resources/js/controllers/users.js # themes/src/main/resources/theme/base/admin/resources/js/loaders.js
|
Closing as we had other PR with this functionality, which added also server-side support. |
|
@guitaro Thanks for your PR anyway. You can check if current master (Keycloak 4.7.0.Final) suits your needs. |
Group pagination responding to JIRA KEYCLOAK-2538. Including fixes detected after #4209 validation (JIRA KEYCLOAK-5701).
Wainting for backup from @patriot1burke and/or @stianst.
Thanks :)