KEYCLOAK-7361 Add !community profile to prod-arguments.json
#5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the community profile to be disabled in the product build. The product profile is active already, but unfortunately maven doesn't allow chained profile activation, so there's no way to automatically disable the community profile when the product profile is active. An alternative solution would have been to add `-Dproduct` to the properties list, but then it wouldn't be clear what was trying to be done with the extra argument. I've checked with `git grep -B3 '!product'`, and the only profiles that use the `!product` property activation condition are the community profiles.
martin-kanis
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the community profile to be disabled in the product build.
The product profile is active already, but unfortunately maven doesn't allow
chained profile activation, so there's no way to automatically disable the
community profile when the product profile is active.
An alternative solution would have been to add
-Dproductto the propertieslist, but then it wouldn't be clear what was trying to be done with the extra
argument.
I've checked with
git grep -B3 '!product', and the only profiles that use the!productproperty activation condition are the community profiles.